You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/06 10:55:00 UTC

Re: Review Request 65343: Adopted `DEFAULT_TEST_TIMEOUT` in libprocess tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65343/#review196877
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/tests/main.cpp
Lines 63 (patched)
<https://reviews.apache.org/r/65343/#comment276769>

    Let's rename this to `test_await_timeout`.



3rdparty/libprocess/src/tests/main.cpp
Lines 68 (patched)
<https://reviews.apache.org/r/65343/#comment276770>

    Rename to `test_await_timeout`.


- Benjamin Bannier


On Jan. 25, 2018, 8:15 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65343/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2018, 8:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Gaston Kleiman.
> 
> 
> Bugs: MESOS-7016
>     https://issues.apache.org/jira/browse/MESOS-7016
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than hard-coding a 15sec test timeout, use the libprocess
> `DEFAULT_TEST_TIMEOUT` variable so that this can be globally tuned.
> Added a test flag `--default_await_timeout` that can be used to set
> the `DEFAULT_TEST_TIMEOUT` on a test run.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/main.cpp 4633bea4caad3ddda809b7b5aa0c5220f8ad82c2 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 8211ae63e75359705af2bb9ac02a7cbdb28e3252 
> 
> 
> Diff: https://reviews.apache.org/r/65343/diff/4/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>