You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Jeff Zhang <zj...@apache.org> on 2018/06/15 00:59:00 UTC
Disable Flaky Test
Hi Folks,
The zeppelin travis become unstable again recently. I know it is really
annoying and frustrated, so I create a PR to disable these flaky tests.
There still some flaky test, but happens in low frequency. According my
experience, if you still have travis build failure after this PR, you can
try to rerun the travis build to get travis build pass. Just rerun the
failed one, don't run the whole travis build matrix and also please clear
travis cache first. If there's no objection, I would commit this PR. And
after that, please keep travis build passed before you commit any new
changes. Thanks.
https://github.com/apache/zeppelin/pull/3020
Re: Disable Flaky Test
Posted by Jongyoul Lee <jo...@gmail.com>.
Hi,
I think it's good but we might need a plan when we enable them again.
Basically, I agree with it.
On Tue, Jun 19, 2018 at 1:49 AM, Jeff Zhang <zj...@gmail.com> wrote:
> Hi Folks,
>
> Seems there's no objection on this, so I assume everyone agree on it. I
> have merged this PR. From now on, please double check the travis status
> before you merge your PR if you are committer and make sure the travis
> build status before you ask others to review if you are not committer. As I
> mentioned before, you need to add unit test for your PR and rerun the
> travis if it still fails. If your PR make the travis failed, every
> committer has the privilege to revert your PR.
>
>
>
> Jeff Zhang <zj...@apache.org>于2018年6月15日周五 上午9:46写道：
>
> >
> > BTW, please* add unit test for any new PR* unless it is very trivial
> > change and other committer agree it is OK without unit test. If you find
> > it is difficult to add unit test. There will be several reasons according
> > my experience.
> >
> > 1. It is due to the architecture and evolution of zeppelin, as more and
> > more components and features added to zeppelin, many things may be
> coupled
> > together which make it difficult to add unit test. In this case, please
> > comment in your PR why it is difficult to add unit test, and what is your
> > plan for that. Code refactoring in some component of zeppelin or unit
> test.
> >
> > 2. It is due to your PR that introduce too much complexity or didn't do
> it
> > in a elegant approach. In this case, please rethink your PR to improve
> it.
> >
> >
> >
> >
> > Jeff Zhang <zj...@apache.org>于2018年6月15日周五 上午8:59写道：
> >
> >> Hi Folks,
> >>
> >> The zeppelin travis become unstable again recently. I know it is really
> >> annoying and frustrated, so I create a PR to disable these flaky tests.
> >> There still some flaky test, but happens in low frequency. According my
> >> experience, if you still have travis build failure after this PR, you
> can
> >> try to rerun the travis build to get travis build pass. Just rerun the
> >> failed one, don't run the whole travis build matrix and also please
> clear
> >> travis cache first. If there's no objection, I would commit this PR. And
> >> after that, please keep travis build passed before you commit any new
> >> changes. Thanks.
> >>
> >> https://github.com/apache/zeppelin/pull/3020
> >>
> >>
>
--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net
Re: Disable Flaky Test
Posted by Jeff Zhang <zj...@gmail.com>.
Hi Folks,
Seems there's no objection on this, so I assume everyone agree on it. I
have merged this PR. From now on, please double check the travis status
before you merge your PR if you are committer and make sure the travis
build status before you ask others to review if you are not committer. As I
mentioned before, you need to add unit test for your PR and rerun the
travis if it still fails. If your PR make the travis failed, every
committer has the privilege to revert your PR.
Jeff Zhang <zj...@apache.org>于2018年6月15日周五 上午9:46写道：
>
> BTW, please* add unit test for any new PR* unless it is very trivial
> change and other committer agree it is OK without unit test. If you find
> it is difficult to add unit test. There will be several reasons according
> my experience.
>
> 1. It is due to the architecture and evolution of zeppelin, as more and
> more components and features added to zeppelin, many things may be coupled
> together which make it difficult to add unit test. In this case, please
> comment in your PR why it is difficult to add unit test, and what is your
> plan for that. Code refactoring in some component of zeppelin or unit test.
>
> 2. It is due to your PR that introduce too much complexity or didn't do it
> in a elegant approach. In this case, please rethink your PR to improve it.
>
>
>
>
> Jeff Zhang <zj...@apache.org>于2018年6月15日周五 上午8:59写道：
>
>> Hi Folks,
>>
>> The zeppelin travis become unstable again recently. I know it is really
>> annoying and frustrated, so I create a PR to disable these flaky tests.
>> There still some flaky test, but happens in low frequency. According my
>> experience, if you still have travis build failure after this PR, you can
>> try to rerun the travis build to get travis build pass. Just rerun the
>> failed one, don't run the whole travis build matrix and also please clear
>> travis cache first. If there's no objection, I would commit this PR. And
>> after that, please keep travis build passed before you commit any new
>> changes. Thanks.
>>
>> https://github.com/apache/zeppelin/pull/3020
>>
>>
Re: Disable Flaky Test
Posted by Jeff Zhang <zj...@apache.org>.
BTW, please* add unit test for any new PR* unless it is very trivial change
and other committer agree it is OK without unit test. If you find it is
difficult to add unit test. There will be several reasons according my
experience.
1. It is due to the architecture and evolution of zeppelin, as more and
more components and features added to zeppelin, many things may be coupled
together which make it difficult to add unit test. In this case, please
comment in your PR why it is difficult to add unit test, and what is your
plan for that. Code refactoring in some component of zeppelin or unit test.
2. It is due to your PR that introduce too much complexity or didn't do it
in a elegant approach. In this case, please rethink your PR to improve it.
Jeff Zhang <zj...@apache.org>于2018年6月15日周五 上午8:59写道：
> Hi Folks,
>
> The zeppelin travis become unstable again recently. I know it is really
> annoying and frustrated, so I create a PR to disable these flaky tests.
> There still some flaky test, but happens in low frequency. According my
> experience, if you still have travis build failure after this PR, you can
> try to rerun the travis build to get travis build pass. Just rerun the
> failed one, don't run the whole travis build matrix and also please clear
> travis cache first. If there's no objection, I would commit this PR. And
> after that, please keep travis build passed before you commit any new
> changes. Thanks.
>
> https://github.com/apache/zeppelin/pull/3020
>
>