[GitHub] [dubbo-go] WilliamLeaves commented on a change in pull request #1297: fix:#1143 Feature/reduce etcd registry conn

[GitBox <gi...@apache.org>]

WilliamLeaves commented on a change in pull request #1297:
URL: https://github.com/apache/dubbo-go/pull/1297#discussion_r666965334



##########
File path: remoting/etcdv3/facade.go
##########
@@ -46,54 +43,16 @@ type clientFacade interface {
 
 // HandleClientRestart keeps the connection between client and server
 func HandleClientRestart(r clientFacade) {
-	var (
-		err       error
-		failTimes int
-	)
-
 	defer r.WaitGroup().Done()

Review comment:
       有可能，用once限制一下HandleClientRestart的调用次数是否可以呢；该方法在init包被引入的时候调用，只调用一次。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org