You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/01/19 22:53:14 UTC
hbase git commit: HBASE-19823 Make RawCellBuilderFactory
LimitedPrivate.UNITTEST
Repository: hbase
Updated Branches:
refs/heads/master 579586c69 -> 4bfdcaa3f
HBASE-19823 Make RawCellBuilderFactory LimitedPrivate.UNITTEST
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4bfdcaa3
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4bfdcaa3
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4bfdcaa3
Branch: refs/heads/master
Commit: 4bfdcaa3f30dd5e898e54a7b37a7231715cd03cc
Parents: 579586c
Author: Apekshit Sharma <ap...@apache.org>
Authored: Thu Jan 18 11:34:21 2018 -0800
Committer: Apekshit Sharma <ap...@apache.org>
Committed: Fri Jan 19 14:53:01 2018 -0800
----------------------------------------------------------------------
.../java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java | 1 +
.../src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java | 3 ++-
.../java/org/apache/hadoop/hbase/RawCellBuilderFactory.java | 5 +++--
3 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/4bfdcaa3/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java
index 3a51bd5..4e03457 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java
@@ -36,6 +36,7 @@ public final class HBaseInterfaceAudience {
public static final String REPLICATION = "Replication";
public static final String PHOENIX = "Phoenix";
public static final String SPARK = "Spark";
+ public static final String UNITTEST = "Unittest";
/**
* Denotes class names that appear in user facing configuration files.
http://git-wip-us.apache.org/repos/asf/hbase/blob/4bfdcaa3/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java
index 9e89307..f779729 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java
@@ -23,7 +23,8 @@ import org.apache.yetus.audience.InterfaceAudience;
/**
* Allows creating a cell with {@link Tag}
- * An instance of this type can be acquired using RegionCoprocessorEnvironment#getCellBuilder.
+ * An instance of this type can be acquired by using RegionCoprocessorEnvironment#getCellBuilder
+ * (for prod code) and {@link RawCellBuilderFactory} (for unit tests).
*/
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC)
public interface RawCellBuilder extends CellBuilder {
http://git-wip-us.apache.org/repos/asf/hbase/blob/4bfdcaa3/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java
index 0f61ee8..f7ff952 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java
@@ -23,10 +23,11 @@ import org.apache.yetus.audience.InterfaceAudience;
/**
* Factory for creating cells for CPs. It does deep_copy {@link CellBuilderType#DEEP_COPY} while
* creating cells.
- * This is private because coprocessors should get an instance of type {@link RawCellBuilder}
+ * This class is limited private only for use in unit-tests.
+ * For non-test uses in coprocessors, get an instance of type {@link RawCellBuilder}
* using RegionCoprocessorEnvironment#getCellBuilder.
*/
-@InterfaceAudience.Private
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.UNITTEST)
public final class RawCellBuilderFactory {
/**