You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/25 10:51:57 UTC

[GitHub] [spark] mazeboard commented on issue #24299: [SPARK-27388][SQL] encoder for objects defined by properties (ie. Avro)

mazeboard commented on issue #24299: [SPARK-27388][SQL] encoder for objects defined by properties (ie. Avro)
URL: https://github.com/apache/spark/pull/24299#issuecomment-495907948
 
 
   > Overall: isn't this what the Encoder for Java Beans is for and already supports? I am not sure it obvious to me this should go in ScalaReflection.
   > Separately I don't think it's worth further supporting JavaBean properties. That's pretty old and rare, I think.
   
   Hi, I would like to hear from about the possibility to merge this PR, many developer teams need to have the possibility to work with Datasets of SpecificRecords (ie. Avro), I implemented a version that modifies the bean encoder but I believe that adding encoders to ScalaReflection is the way to go for reason I explained in this PR, please let me know if this can be considered as a viable solution

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org