You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/01/28 18:11:28 UTC
[GitHub] [wicket] reiern70 opened a new pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
reiern70 opened a new pull request #496:
URL: https://github.com/apache/wicket/pull/496
allow configuring web-sockets sessions when connection is opened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795653507
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/IWebSocketProcessor.java
##########
@@ -16,13 +16,20 @@
*/
package org.apache.wicket.protocol.ws.api;
+import org.apache.wicket.protocol.http.WebApplication;
+import org.apache.wicket.protocol.ws.WebSocketSettings;
+
/**
* Processes web socket messages.
*
* @since 6.0
*/
public interface IWebSocketProcessor
{
+ default void onOpen(IWebSocketSession webSocketSession, final WebApplication application) {
Review comment:
@martin-g
I will. I just wanted to get your opinion on the whole thing and double check if there was another way to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r796215209
##########
File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java
##########
@@ -59,11 +66,22 @@ public void init()
getSharedResources().add(ChartWebSocketResource.NAME, new ChartWebSocketResource());
+ final WebSocketSettings webSocketSettings = WebSocketSettings.Holder.get(this);
+
+ webSocketSettings.setSocketSessionConfigurer(new IWebSocketSessionConfigurer() {
Review comment:
I was not sure what was the accepted style in examples... we use extensively lambdas in our project. I will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795654808
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/IWebSocketSession.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.wicket.protocol.ws.api;
+
+import java.net.URI;
+import java.security.Principal;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Wicket proxy interface to javax.websocket.Session.
+ */
+public interface IWebSocketSession
+{
+
+ /**
+ * See javax.websocket.Session#getProtocolVersion()
Review comment:
@martin-g Mind I could not use `@link` javadoc thing because` javax.websocket.Session` is not part of the class path and then build fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on pull request #496:
URL: https://github.com/apache/wicket/pull/496#issuecomment-1025975462
@martin-g I have included your suggestion + commnets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on pull request #496:
URL: https://github.com/apache/wicket/pull/496#issuecomment-1026047297
org.eclipse.jetty.websocket.api.CloseException: java.util.concurrent.TimeoutException: Idle timeout expired: 60000/60000 ms
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onReadTimeout(AbstractWebSocketConnection.java:564)
at org.eclipse.jetty.io.AbstractConnection.onFillInterestedFailed(AbstractConnection.java:172)
at org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillInterestedFailed(AbstractWebSocketConnection.java:539)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.failed(AbstractConnection.java:317)
at org.eclipse.jetty.io.FillInterest.onFail(FillInterest.java:140)
at org.eclipse.jetty.io.AbstractEndPoint.onIdleExpired(AbstractEndPoint.java:407)
at org.eclipse.jetty.io.IdleTimeout.checkIdleTimeout(IdleTimeout.java:171)
at org.eclipse.jetty.io.IdleTimeout.idleCheck(IdleTimeout.java:113)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java)
at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.util.concurrent.TimeoutException: Idle timeout expired: 60000/60000 ms
It seems this works as expected. Set it to one minute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on pull request #496:
URL: https://github.com/apache/wicket/pull/496#issuecomment-1026409813
@martin-g Many thanks for review and comments. This landed in wicket-9.x branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795995115
##########
File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java
##########
@@ -59,11 +66,22 @@ public void init()
getSharedResources().add(ChartWebSocketResource.NAME, new ChartWebSocketResource());
+ final WebSocketSettings webSocketSettings = WebSocketSettings.Holder.get(this);
+
+ webSocketSettings.setSocketSessionConfigurer(new IWebSocketSessionConfigurer() {
Review comment:
you can be cool and use lambda here :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 merged pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 merged pull request #496:
URL: https://github.com/apache/wicket/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795659246
##########
File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java
##########
@@ -59,11 +65,22 @@ public void init()
getSharedResources().add(ChartWebSocketResource.NAME, new ChartWebSocketResource());
+ final WebSocketSettings webSocketSettings = new WebSocketSettings() {
+ @Override
+ public void configureSession(IWebSocketSession webSocketSession) {
+ LOGGER.info("getMaxIdleTimeout = " + webSocketSession.getMaxIdleTimeout());
+ // make sessions almost "immortal"
+ webSocketSession.setMaxIdleTimeout(Duration.ofHours(10).toMillis());
Review comment:
@martin-g I saw locally disconnection happening after a few millisecond of inactivity. Mind connection will be closed once user navigates away from page. One interesting fact is that specification states that 0 or negative means for ever, but jetty does not accepts negative values (it throws an exception) and 0 seems to be really 0. I will double check. What value would you use here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on pull request #496:
URL: https://github.com/apache/wicket/pull/496#issuecomment-1026049655
Setting it to -1 produces
java.lang.IllegalArgumentException: IdleTimeout [-1] must be a greater than or equal to 0
at org.eclipse.jetty.websocket.api.WebSocketPolicy.assertGreaterThan(WebSocketPolicy.java:117)
at org.eclipse.jetty.websocket.api.WebSocketPolicy.setIdleTimeout(WebSocketPolicy.java:300)
at org.eclipse.jetty.websocket.jsr356.JsrSession.setMaxIdleTimeout(JsrSession.java:351)
at org.apache.wicket.protocol.ws.javax.JavaxWebSocketSession.setMaxIdleTimeout(JavaxWebSocketSession.java:73)
at org.apache.wicket.examples.websocket.JSR356Application$1.configureSession(JSR356Application.java:76)
at org.apache.wicket.protocol.ws.api.IWebSocketProcessor.onOpen(IWebSocketProcessor.java:41)
at org.apache.wicket.protocol.ws.javax.WicketEndpoint.onOpen(WicketEndpoint.java:74)
at org.eclipse.jetty.websocket.jsr356.endpoints.JsrEndpointEventDriver.onConnect(JsrEndpointEventDriver.java:145)
at org.eclipse.jetty.websocket.common.events.AbstractEventDriver.openSession(AbstractEventDriver.java:217)
at org.eclipse.jetty.websocket.jsr356.endpoints.AbstractJsrEventDriver.openSession(AbstractJsrEventDriver.java:107)
at org.eclipse.jetty.websocket.common.WebSocketSession.open(WebSocketSession.java:493)
at org.eclipse.jetty.websocket.common.WebSocketSession.onOpened(WebSocketSession.java:459)
at org.eclipse.jetty.io.AbstractConnection.onOpened(AbstractConnection.java:213)
at org.eclipse.jetty.io.AbstractConnection.onOpen(AbstractConnection.java:205)
at org.eclipse.jetty.io.AbstractEndPoint.upgrade(AbstractEndPoint.java:444)
at org.eclipse.jetty.server.HttpConnection.onCompleted(HttpConnection.java:412)
at org.eclipse.jetty.server.HttpChannel.onCompleted(HttpChannel.java:832)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.produce(EatWhatYouKill.java:137)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
at java.base/java.lang.Thread.run(Thread.java:829)
Thus jetty implementation does not stick to "standard"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795992677
##########
File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java
##########
@@ -59,11 +65,22 @@ public void init()
getSharedResources().add(ChartWebSocketResource.NAME, new ChartWebSocketResource());
+ final WebSocketSettings webSocketSettings = new WebSocketSettings() {
+ @Override
+ public void configureSession(IWebSocketSession webSocketSession) {
+ LOGGER.info("getMaxIdleTimeout = " + webSocketSession.getMaxIdleTimeout());
+ // make sessions almost "immortal"
+ webSocketSession.setMaxIdleTimeout(Duration.ofHours(10).toMillis());
Review comment:
5 mins at most. This is just a demo, we don't guarantee 99.999% SLA :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795267460
##########
File path: wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java
##########
@@ -43,6 +46,118 @@
*/
public class WicketEndpoint extends Endpoint
{
+ private static class JavaxWebSocketSessionWrapper implements IWebSocketSession
Review comment:
Let's move this class as a non-inner class with package-private visibility.
Also its name could be `JavaxWebSocketSession` to be more consistent with the other classes in -javax module.
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/IWebSocketProcessor.java
##########
@@ -16,13 +16,20 @@
*/
package org.apache.wicket.protocol.ws.api;
+import org.apache.wicket.protocol.http.WebApplication;
+import org.apache.wicket.protocol.ws.WebSocketSettings;
+
/**
* Processes web socket messages.
*
* @since 6.0
*/
public interface IWebSocketProcessor
{
+ default void onOpen(IWebSocketSession webSocketSession, final WebApplication application) {
Review comment:
Please add javadoc
##########
File path: wicket-examples/src/main/java/org/apache/wicket/examples/websocket/JSR356Application.java
##########
@@ -59,11 +65,22 @@ public void init()
getSharedResources().add(ChartWebSocketResource.NAME, new ChartWebSocketResource());
+ final WebSocketSettings webSocketSettings = new WebSocketSettings() {
+ @Override
+ public void configureSession(IWebSocketSession webSocketSession) {
+ LOGGER.info("getMaxIdleTimeout = " + webSocketSession.getMaxIdleTimeout());
+ // make sessions almost "immortal"
+ webSocketSession.setMaxIdleTimeout(Duration.ofHours(10).toMillis());
Review comment:
Is this a good idea ?
We hosts the examples at https://examples9x.wicket.apache.org/websockets/
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
##########
@@ -245,6 +246,16 @@ public Executor getSendPayloadExecutor()
return sendPayloadExecutor;
}
+ /**
+ * Allows to configure {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ *
+ * @param webSocketSession The {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ */
+ public void configureSession(IWebSocketSession webSocketSession)
Review comment:
I wonder whether we need more abstractions here.
It feels weird a Settings class to `do` something. Usually the Settings classes have setters/getters for the do-ers.
E.g.
```java
public void setWebSocketSessionConfigurer(IWebSocketSessionConfigurer configurer)
{
this.webSocketSessionConfigurer = Args.nonNull(configurer, "configurer");
}
```
The default configurer would do nothing in its `#configure()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] martin-g commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795993193
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/IWebSocketSession.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.wicket.protocol.ws.api;
+
+import java.net.URI;
+import java.security.Principal;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Wicket proxy interface to javax.websocket.Session.
+ */
+public interface IWebSocketSession
+{
+
+ /**
+ * See javax.websocket.Session#getProtocolVersion()
Review comment:
Yep! I know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795652283
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
##########
@@ -245,6 +246,16 @@ public Executor getSendPayloadExecutor()
return sendPayloadExecutor;
}
+ /**
+ * Allows to configure {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ *
+ * @param webSocketSession The {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ */
+ public void configureSession(IWebSocketSession webSocketSession)
Review comment:
Yes...you are right. We are somehow "forcing" the settings class to acta as a listener. Thus we might need to introduce a Listener/Configurer that is set in Setting and laster on called. This might be more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r796214845
##########
File path: wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketEndpoint.java
##########
@@ -43,6 +46,118 @@
*/
public class WicketEndpoint extends Endpoint
{
+ private static class JavaxWebSocketSessionWrapper implements IWebSocketSession
Review comment:
done
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
##########
@@ -245,6 +246,16 @@ public Executor getSendPayloadExecutor()
return sendPayloadExecutor;
}
+ /**
+ * Allows to configure {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ *
+ * @param webSocketSession The {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ */
+ public void configureSession(IWebSocketSession webSocketSession)
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [wicket] reiern70 commented on pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
Posted by GitBox <gi...@apache.org>.
reiern70 commented on pull request #496:
URL: https://github.com/apache/wicket/pull/496#issuecomment-1026409967
I will create PR for master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org