Re: [PR] Roll forward "Read API Source v2 (#25392)" fix data loss [beam]

["vachan-shetty (via GitHub)" <gi...@apache.org>]

vachan-shetty commented on code in PR #28778:
URL: https://github.com/apache/beam/pull/28778#discussion_r1511899211


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryOptions.java:
##########
@@ -165,10 +165,10 @@ public interface BigQueryOptions
   void setStorageWriteApiMaxRequestSize(Long value);
 
   @Description(
-      "If set, BigQueryIO.Read will use the StreamBundle based"
-          + "implementation of the Read API Source")
+      "If set, BigQueryIO.Read will rely on the Read API backends to surface the appropriate"
+          + " number of streams for read")
   @Default.Boolean(false)
-  Boolean getEnableBundling();
+  Boolean getEnableStorageReadApiV2();
 
-  void setEnableBundling(Boolean value);
+  void setEnableStorageReadApiV2(Boolean value);

Review Comment:
   Nit: Could we rename this to `enableStorageReadApiSourceV2`? 
   
   There are currently multiple versions of the Read API and the current name could possibly be confusing as to which version of the API is being used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org