[GitHub] szha commented on a change in pull request #7662: WIP: Isolated benchmarking support

[gi...@git.apache.org]

szha commented on a change in pull request #7662: WIP: Isolated benchmarking support
URL: https://github.com/apache/incubator-mxnet/pull/7662#discussion_r136143459
 
 

 ##########
 File path: benchmark/python/sparse/sparse_end2end.py
 ##########
 @@ -169,7 +169,7 @@ def row_sparse_pull(kv, key, data, slices, weight_array, priority):
     compute_only = args.compute_only
     communication_only = args.communication_only
     if (compute_only and io_only) or (compute_only and communication_only) or (io_only and communication_only):
-        raise Exception("Only one of compute_only, io_only, communication_only can be set")
+        assert False, "Only one of compute_only, io_only, communication_only can be set"
 
 Review comment:
   `assert compute_only + io_only + communication_only <= 1`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services