You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/05/06 20:26:30 UTC
[jira] Created: (ZOOKEEPER-391) bookeeper mainline code should not
be calling printStackTrace
bookeeper mainline code should not be calling printStackTrace
-------------------------------------------------------------
Key: ZOOKEEPER-391
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391
Project: Zookeeper
Issue Type: Bug
Components: contrib-bookkeeper
Reporter: Patrick Hunt
Fix For: 3.2.0
Bookeeper mainline code is calling printStackTrace, it should be using logging instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-391) bookeeper mainline code should not
be calling printStackTrace
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-391:
---------------------------------------------
Status: Patch Available (was: Open)
> bookeeper mainline code should not be calling printStackTrace
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-391.patch
>
>
> Bookeeper mainline code is calling printStackTrace, it should be using logging instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-391) bookeeper mainline code should
not be calling printStackTrace
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708935#action_12708935 ]
Hudson commented on ZOOKEEPER-391:
----------------------------------
Integrated in ZooKeeper-trunk #308 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/308/])
. bookeeper mainline code should not be calling printStackTrace. (flavio via mahadev)
> bookeeper mainline code should not be calling printStackTrace
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-391.patch
>
>
> Bookeeper mainline code is calling printStackTrace, it should be using logging instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-391) bookeeper mainline code should not
be calling printStackTrace
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-391:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1. I just committed this.
> bookeeper mainline code should not be calling printStackTrace
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-391.patch
>
>
> Bookeeper mainline code is calling printStackTrace, it should be using logging instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-391) bookeeper mainline code should not
be calling printStackTrace
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira reassigned ZOOKEEPER-391:
------------------------------------------------
Assignee: Flavio Paiva Junqueira
> bookeeper mainline code should not be calling printStackTrace
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
>
> Bookeeper mainline code is calling printStackTrace, it should be using logging instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-391) bookeeper mainline code should
not be calling printStackTrace
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708286#action_12708286 ]
Hadoop QA commented on ZOOKEEPER-391:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407773/ZOOKEEPER-391.patch
against trunk revision 772843.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/69/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/69/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/69/console
This message is automatically generated.
> bookeeper mainline code should not be calling printStackTrace
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-391.patch
>
>
> Bookeeper mainline code is calling printStackTrace, it should be using logging instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-391) bookeeper mainline code should not
be calling printStackTrace
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-391:
---------------------------------------------
Attachment: ZOOKEEPER-391.patch
Thanks for pointing it out, Pat. This patch replaces calls to printStackTrace with calls to the log4j logger.
> bookeeper mainline code should not be calling printStackTrace
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-391
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-391.patch
>
>
> Bookeeper mainline code is calling printStackTrace, it should be using logging instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.