You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by adityasharad <gi...@git.apache.org> on 2017/05/29 14:08:20 UTC

[GitHub] storm pull request #2143: STORM-2503: Restore comparator logic in `DefaultRe...

GitHub user adityasharad opened a pull request:

    https://github.com/apache/storm/pull/2143

    STORM-2503: Restore comparator logic in `DefaultResourceAwareStrategy`.

    This PR ensures consistent comparator ordering in the above class, using descending order in both `sortNeighbors` and `sortComponents` and adding comments to indicate descending order.
    
    As requested by @jerrypeng on https://github.com/apache/storm/pull/2100.
    @revans2

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adityasharad/storm fix/resource-aware-strategy-neighbors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2143
    
----
commit 3ceaba8873ff172285231f1234713df053d7e96d
Author: Aditya Sharad <ad...@semmle.com>
Date:   2017-05-29T14:04:46Z

    STORM-2503: Restore comparator logic in `DefaultResourceAwareStrategy`.
    
    Use descending order in both `sortNeighbors` and `sortComponents`.
    Add comments to indicate descending order.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2143: STORM-2503: Restore comparator logic in `DefaultResourceA...

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2143
  
    @jerrypeng Like I said in the previous pull request.  The unit test that failed was not cause by this change.  It was cause by an actual fix to the comparison logic for `sortComponents`.  In my tests I saw the output of `sortComponents` having duplicate entries prior to that fix.
    
    I am +1 for this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2143: STORM-2503: Restore comparator logic in `DefaultResourceA...

Posted by jerrypeng <gi...@git.apache.org>.

Github user jerrypeng commented on the issue:

    https://github.com/apache/storm/pull/2143
  
    @adityasharad Thanks for changing it back.  What about the unit test that was modified as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2143: STORM-2503: Restore comparator logic in `DefaultRe...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2143


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---