You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/18 12:54:36 UTC

[GitHub] [commons-csv] garydgregory commented on a change in pull request #127: Minor Improvement

garydgregory commented on a change in pull request #127:
URL: https://github.com/apache/commons-csv/pull/127#discussion_r545812569



##########
File path: src/main/java/org/apache/commons/csv/CSVFormat.java
##########
@@ -1629,6 +1629,7 @@ private CharSequence trim(final CharSequence charSequence) {
      * Verifies the consistency of the parameters and throws an IllegalArgumentException if necessary.
      *
      * @throws IllegalArgumentException
+     *             thrown if the delimiter is a scape character

Review comment:
       "scape"?

##########
File path: src/test/java/org/apache/commons/csv/CSVParserTest.java
##########
@@ -572,7 +572,7 @@ public void testGetOneLine() throws IOException {
     /**
      * Tests reusing a parser to process new string records one at a time as they are being discovered. See [CSV-110].
      *
-     * @throws IOException
+     * @throws Exception Any exception can be thrown

Review comment:
       Does not match the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org