You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/05 19:07:48 UTC
Review Request 55224: Removed unused namespace alias declarations in
mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55224/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Spotted with clang-tidy.
Diffs
-----
src/launcher/posix/executor.cpp a29b31c14f23d0c60f1bffc5a98c21c2935f0ce0
src/tests/slave_validation_tests.cpp 217e0edec7367e34836bf9b178853b18cbbf0632
Diff: https://reviews.apache.org/r/55224/diff/
Testing
-------
`make check` on OSX and Linux, plus internal CI.
Thanks,
Neil Conway
Re: Review Request 55224: Removed unused namespace alias declarations
in mesos.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55224/#review160673
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55218, 55219, 55226, 55220, 55221, 55222, 55223, 55224]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 5, 2017, 8:07 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55224/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 8:07 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Spotted with clang-tidy.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp cc9adfe6af18a0fc90be93c40590375f7bc00eaf
> src/launcher/posix/executor.cpp a29b31c14f23d0c60f1bffc5a98c21c2935f0ce0
> src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp b470f0c829ab398f3a45a0467ad25d6adfa17942
> src/slave/containerizer/mesos/provisioner/provisioner.cpp db2d267996959453f9896287320dca37440b499b
> src/tests/containerizer/capabilities_test_helper.cpp 17f00b00656bdd553e2021771c4230910781762b
> src/tests/containerizer/provisioner_appc_tests.cpp 8b4b832a8fc022435b4d1ada8b8fd9c392ce685e
> src/tests/registrar_tests.cpp 0433b26f47d25e819533706fe1adbe210b5b6bcf
> src/tests/slave_validation_tests.cpp 217e0edec7367e34836bf9b178853b18cbbf0632
>
> Diff: https://reviews.apache.org/r/55224/diff/
>
>
> Testing
> -------
>
> `make check` on OSX and Linux, plus internal CI.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55224: Removed unused namespace alias declarations
in mesos.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55224/#review160989
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Jan. 5, 2017, 12:07 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55224/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 12:07 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Spotted with clang-tidy.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp cc9adfe6af18a0fc90be93c40590375f7bc00eaf
> src/launcher/posix/executor.cpp a29b31c14f23d0c60f1bffc5a98c21c2935f0ce0
> src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp b470f0c829ab398f3a45a0467ad25d6adfa17942
> src/slave/containerizer/mesos/provisioner/provisioner.cpp db2d267996959453f9896287320dca37440b499b
> src/tests/containerizer/capabilities_test_helper.cpp 17f00b00656bdd553e2021771c4230910781762b
> src/tests/containerizer/provisioner_appc_tests.cpp 8b4b832a8fc022435b4d1ada8b8fd9c392ce685e
> src/tests/registrar_tests.cpp 0433b26f47d25e819533706fe1adbe210b5b6bcf
> src/tests/slave_validation_tests.cpp 217e0edec7367e34836bf9b178853b18cbbf0632
>
> Diff: https://reviews.apache.org/r/55224/diff/
>
>
> Testing
> -------
>
> `make check` on OSX and Linux, plus internal CI.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55224: Removed unused namespace alias declarations
in mesos.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55224/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 8:07 p.m.)
Review request for mesos and Michael Park.
Changes
-------
More fixes.
Repository: mesos
Description
-------
Spotted with clang-tidy.
Diffs (updated)
-----
src/launcher/executor.cpp cc9adfe6af18a0fc90be93c40590375f7bc00eaf
src/launcher/posix/executor.cpp a29b31c14f23d0c60f1bffc5a98c21c2935f0ce0
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp b470f0c829ab398f3a45a0467ad25d6adfa17942
src/slave/containerizer/mesos/provisioner/provisioner.cpp db2d267996959453f9896287320dca37440b499b
src/tests/containerizer/capabilities_test_helper.cpp 17f00b00656bdd553e2021771c4230910781762b
src/tests/containerizer/provisioner_appc_tests.cpp 8b4b832a8fc022435b4d1ada8b8fd9c392ce685e
src/tests/registrar_tests.cpp 0433b26f47d25e819533706fe1adbe210b5b6bcf
src/tests/slave_validation_tests.cpp 217e0edec7367e34836bf9b178853b18cbbf0632
Diff: https://reviews.apache.org/r/55224/diff/
Testing
-------
`make check` on OSX and Linux, plus internal CI.
Thanks,
Neil Conway