You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2019/01/09 09:47:04 UTC
Geronimo OpenAPI maven plugin coming changes
Hi guys,
I'm planning to enable to configure info part of the maven plugin for
openapi today + add a few fixes for implicit configuration for returned
types (they are not always populated)
Then I'm planning to launch a release, any objection?
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Re: Geronimo OpenAPI maven plugin coming changes
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Oki, just a quick note it is tested
in org.eclipse.microprofile.openapi.tck.AirlinesAppTest so can be something
more vicious :(
Le ven. 11 janv. 2019 01:07, Ivan Junckes Filho <iv...@gmail.com> a
écrit :
> If I annotate this to give the general info about the app it doesn't work
> in the /openapi endpoint.
>
> @OpenAPIDefinition(info = @Info(title = "App Name", version = "1.0"))
>
> I should be opening a ticket soon. I also would like to work on this when I have time in the future.
>
>
> On Wed, Jan 9, 2019 at 5:38 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> Kind of. This part is processed but when using the maven plugin you dont
>> always want to even use as provided the mp api to pollute your code with
>> that so we can now configure this mandatory part in the pom or defaults are
>> provided to generate a valid openapi.json.
>>
>> Without that info set the openapi.json misses it. I know cxf was used to
>> set default wrong values to pass validator but it also exposes wrong data
>> so i prefer we generate an invalid doc than swallowing an error.
>>
>> Is it the issue you are soeaking about? Or did you find another case - i
>> know with some ioc lib proxies can swallow annotation but i guess you
>> tested on tomee so it should be fine?
>>
>> Le mer. 9 janv. 2019 18:38, Ivan Junckes Filho <iv...@gmail.com> a
>> écrit :
>>
>>> Hey Romain, when you say info are you talking about the annotations
>>> below? I was planning to open an issue to have that information in the open
>>> api document. Is this the same issue?
>>>
>>> @OpenAPIDefinition(info = @Info(title = "App Name", version = "1.0"))
>>>
>>>
>>>
>>>
>>> On Wed, Jan 9, 2019 at 7:47 AM Romain Manni-Bucau <rm...@gmail.com>
>>> wrote:
>>>
>>>> Hi guys,
>>>>
>>>> I'm planning to enable to configure info part of the maven plugin for
>>>> openapi today + add a few fixes for implicit configuration for returned
>>>> types (they are not always populated)
>>>> Then I'm planning to launch a release, any objection?
>>>>
>>>> Romain Manni-Bucau
>>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>>> <http://rmannibucau.wordpress.com> | Github
>>>> <https://github.com/rmannibucau> | LinkedIn
>>>> <https://www.linkedin.com/in/rmannibucau> | Book
>>>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>>>
>>>
Re: Geronimo OpenAPI maven plugin coming changes
Posted by Ivan Junckes Filho <iv...@gmail.com>.
If I annotate this to give the general info about the app it doesn't work
in the /openapi endpoint.
@OpenAPIDefinition(info = @Info(title = "App Name", version = "1.0"))
I should be opening a ticket soon. I also would like to work on this
when I have time in the future.
On Wed, Jan 9, 2019 at 5:38 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Kind of. This part is processed but when using the maven plugin you dont
> always want to even use as provided the mp api to pollute your code with
> that so we can now configure this mandatory part in the pom or defaults are
> provided to generate a valid openapi.json.
>
> Without that info set the openapi.json misses it. I know cxf was used to
> set default wrong values to pass validator but it also exposes wrong data
> so i prefer we generate an invalid doc than swallowing an error.
>
> Is it the issue you are soeaking about? Or did you find another case - i
> know with some ioc lib proxies can swallow annotation but i guess you
> tested on tomee so it should be fine?
>
> Le mer. 9 janv. 2019 18:38, Ivan Junckes Filho <iv...@gmail.com> a
> écrit :
>
>> Hey Romain, when you say info are you talking about the annotations
>> below? I was planning to open an issue to have that information in the open
>> api document. Is this the same issue?
>>
>> @OpenAPIDefinition(info = @Info(title = "App Name", version = "1.0"))
>>
>>
>>
>>
>> On Wed, Jan 9, 2019 at 7:47 AM Romain Manni-Bucau <rm...@gmail.com>
>> wrote:
>>
>>> Hi guys,
>>>
>>> I'm planning to enable to configure info part of the maven plugin for
>>> openapi today + add a few fixes for implicit configuration for returned
>>> types (they are not always populated)
>>> Then I'm planning to launch a release, any objection?
>>>
>>> Romain Manni-Bucau
>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>> <http://rmannibucau.wordpress.com> | Github
>>> <https://github.com/rmannibucau> | LinkedIn
>>> <https://www.linkedin.com/in/rmannibucau> | Book
>>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>>
>>
Re: Geronimo OpenAPI maven plugin coming changes
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Kind of. This part is processed but when using the maven plugin you dont
always want to even use as provided the mp api to pollute your code with
that so we can now configure this mandatory part in the pom or defaults are
provided to generate a valid openapi.json.
Without that info set the openapi.json misses it. I know cxf was used to
set default wrong values to pass validator but it also exposes wrong data
so i prefer we generate an invalid doc than swallowing an error.
Is it the issue you are soeaking about? Or did you find another case - i
know with some ioc lib proxies can swallow annotation but i guess you
tested on tomee so it should be fine?
Le mer. 9 janv. 2019 18:38, Ivan Junckes Filho <iv...@gmail.com> a
écrit :
> Hey Romain, when you say info are you talking about the annotations below?
> I was planning to open an issue to have that information in the open api
> document. Is this the same issue?
>
> @OpenAPIDefinition(info = @Info(title = "App Name", version = "1.0"))
>
>
>
>
> On Wed, Jan 9, 2019 at 7:47 AM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> Hi guys,
>>
>> I'm planning to enable to configure info part of the maven plugin for
>> openapi today + add a few fixes for implicit configuration for returned
>> types (they are not always populated)
>> Then I'm planning to launch a release, any objection?
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> | LinkedIn
>> <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>
Re: Geronimo OpenAPI maven plugin coming changes
Posted by Ivan Junckes Filho <iv...@gmail.com>.
Hey Romain, when you say info are you talking about the annotations below?
I was planning to open an issue to have that information in the open api
document. Is this the same issue?
@OpenAPIDefinition(info = @Info(title = "App Name", version = "1.0"))
On Wed, Jan 9, 2019 at 7:47 AM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Hi guys,
>
> I'm planning to enable to configure info part of the maven plugin for
> openapi today + add a few fixes for implicit configuration for returned
> types (they are not always populated)
> Then I'm planning to launch a release, any objection?
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>