You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "w3lld1 (via GitHub)" <gi...@apache.org> on 2026/07/19 16:53:15 UTC
[PR] fix(docs): keep right menu below sticky header [lucenenet]
w3lld1 opened a new pull request, #1425:
URL: https://github.com/apache/lucenenet/pull/1425
- [x] I've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [x] I've included unit or integration tests for my change, where applicable.
- [x] I've included inline docs for my change, where applicable.
- [x] There's an open issue for the PR that I am making.
Keep the desktop docs side menu below the sticky header
Fixes #1407
## Description
I increased the desktop offset for the API docs side affix so its first entries no longer sit underneath the wrapped sticky header at viewport widths of 1200px and above.
I verified the change against the current 4.8.0-beta00018 docs page by replacing its stylesheet in headless Chromium with this branch's stylesheet. At 1200, 1215, 1280, 1350, and 1600px, the 195px-tall header ends before the side menu starts at 200px, and every visible menu entry remains inside the viewport.
## Validation
- `uvx prek run --files websites/apidocs/Templates/LuceneTemplateAssets/styles/main.css`
- Headless Chromium layout regression check at 1200, 1215, 1280, 1350, and 1600px
- `git diff --check origin/master...HEAD`
I did not run the complete Windows-based DocFX website build locally; the browser regression check exercises the changed stylesheet against the published docs markup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(docs): keep right menu below sticky header [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin merged PR #1425:
URL: https://github.com/apache/lucenenet/pull/1425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(docs): keep right menu below sticky header [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on PR #1425:
URL: https://github.com/apache/lucenenet/pull/1425#issuecomment-5186782787
@w3lld1 Thanks for the contribution! I think the HTML/CSS is going to need a bigger overhaul than this, but at least this fixes the issue for now. That way, by merging this, we at least get it fixed if we can't get around to cleaning up the HTML/CSS by the next release. Merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org