You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/21 05:09:31 UTC
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #7116: [To rel/0.13] [OTDB-4089] Storage Group add attribute "number of Virtual Storage Groups"
qiaojialin commented on code in PR #7116:
URL: https://github.com/apache/iotdb/pull/7116#discussion_r1053988300
##########
server/src/test/java/org/apache/iotdb/db/writelog/io/LogWriterReaderTest.java:
##########
@@ -52,24 +50,36 @@ public void prepare() throws IllegalPathException {
if (new File(filePath).exists()) {
new File(filePath).delete();
}
- InsertRowPlan insertRowPlan1 =
- new InsertRowPlan(
- new PartialPath("d1"),
- 10L,
- new String[] {"s1", "s2"},
- new TSDataType[] {TSDataType.INT64, TSDataType.INT64},
- new String[] {"1", "2"});
- InsertRowPlan insertRowPlan2 =
- new InsertRowPlan(
- new PartialPath("d1"),
- 10L,
- new String[] {"s1", "s2"},
- new TSDataType[] {TSDataType.INT64, TSDataType.INT64},
- new String[] {"1", "2"});
- DeletePlan deletePlan = new DeletePlan(Long.MIN_VALUE, 10L, new PartialPath("root.d1.s1"));
- plans.add(insertRowPlan1);
- plans.add(insertRowPlan2);
- plans.add(deletePlan);
+ // InsertRowPlan insertRowPlan1 =
+ // new InsertRowPlan(
+ // new PartialPath("d1"),
+ // 10L,
+ // new String[] {"s1", "s2"},
+ // new TSDataType[] {TSDataType.INT64, TSDataType.INT64},
+ // new String[] {"1", "2"});
+ // InsertRowPlan insertRowPlan2 =
+ // new InsertRowPlan(
+ // new PartialPath("d1"),
+ // 10L,
+ // new String[] {"s1", "s2"},
+ // new TSDataType[] {TSDataType.INT64, TSDataType.INT64},
+ // new String[] {"1", "2"});
+ // DeletePlan deletePlan = new DeletePlan(Long.MIN_VALUE, 10L, new
+ // PartialPath("root.d1.s1"));
+ // plans.add(insertRowPlan1);
+ // plans.add(insertRowPlan2);
+ // plans.add(deletePlan);
Review Comment:
remove useless code
##########
server/src/test/java/org/apache/iotdb/db/qp/physical/PhysicalPlanTest.java:
##########
@@ -1424,10 +1424,17 @@ public void testShowFunction() throws QueryProcessException {
}
@Test
- public void testCreateStorageGroup() throws QueryProcessException {
+ public void testCreateStorageGroup1() throws QueryProcessException {
String sqlStr = "CREATE STORAGE GROUP root.sg";
SetStorageGroupPlan plan = (SetStorageGroupPlan) processor.parseSQLToPhysicalPlan(sqlStr);
- assertEquals("SetStorageGroup{root.sg}", plan.toString());
+ assertEquals("SetStorageGroup{root.sg,1}", plan.toString());
+ }
+
+ @Test
+ public void testCreateStorageGroup2() throws QueryProcessException {
+ String sqlStr = "CREATE STORAGE GROUP root.sg virtualstoragegroupnum = 8";
Review Comment:
Add an IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org