[GitHub] [shardingsphere] terrymanu commented on a change in pull request #11887: Fix the problem that the select now() command returns the wrong format

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #11887:
URL: https://github.com/apache/shardingsphere/pull/11887#discussion_r691286990



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/DatabaseCommunicationEngine.java
##########
@@ -207,7 +207,7 @@ public QueryResponseRow getQueryResponseRow() throws SQLException {
         List<QueryResponseCell> cells = new ArrayList<>(queryHeaders.size());
         boolean isBinary = isBinary();
         for (int columnIndex = 1; columnIndex <= queryHeaders.size(); columnIndex++) {
-            Object data = mergedResult.getValue(columnIndex, Object.class);
+            Object data = mergedResult.getValue(columnIndex, queryHeaders.get(columnIndex - 1).getColumnType() == 93 ? String.class : Object.class);

Review comment:
       What's mean of 93, could you define a constant for it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org