You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "oliveryasuna (via GitHub)" <gi...@apache.org> on 2023/09/04 01:05:41 UTC
[GitHub] [maven-site] oliveryasuna opened a new pull request, #445: Update pom.apt.vm
oliveryasuna opened a new pull request, #445:
URL: https://github.com/apache/maven-site/pull/445
Replaced link to "Maven 2 Pom Demystified".
The current link no longer works. I replaced it with the latest working Internet Archive link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1895690305
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
so we should close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #445: Update pom.apt.vm
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1320869464
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
Thanks for the catch. We don't necessarily have to go full Turabian here, but if the URL doesn't work we could use a more classical citation "The Maven 2 POM demystified
The evolution of a project model", Eric Redmond, JavaWorld.com, 05/29/2006
or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1895571954
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
As I updated many lines of the `pom.apt.vm`in my PR #601, I also changed that line to
> Aspects of this guide were originally published in the article "Maven 2 Pom Demystified The evolution of a project model" by Eric Redmond (JavaWorld.com, 2006-05-29).
I think it's okay for you, @oliveryasuna, as you have the desicion handed over to the maintainers (@elharo and @cstamas here) and I picked up their intention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1453761767
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
@elharo I'm with your solution, no need a link to archive to Maven2...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "oliveryasuna (via GitHub)" <gi...@apache.org>.
oliveryasuna commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1344760993
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
Whatever you think makes sense. I'll let the usual maintainers take it from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo closed pull request #445: Update pom.apt.vm
URL: https://github.com/apache/maven-site/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1895641699
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
Do you need to push this change? I don't see it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1895684131
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
> Do you need to push this change? I don't see it.
I integrated it in #601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update pom.apt.vm [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #445:
URL: https://github.com/apache/maven-site/pull/445#discussion_r1895706812
##########
content/apt/pom.apt.vm:
##########
@@ -2033,4 +2033,4 @@ mvn help:active-profiles
======================
Aspects of this guide were originally published in the
- {{{http://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
+ {{{https://web.archive.org/web/20100327140148/https://www.javaworld.com/javaworld/jw-05-2006/jw-0529-maven.html}Maven 2 Pom Demystified}}.
Review Comment:
> so we should close this PR?
Yes I think this PR (445) can be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org