[jira] [Commented] (MINIFICPP-502) Support required processor properties

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483244#comment-16483244 ] 

ASF GitHub Bot commented on MINIFICPP-502:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/334#discussion_r189747932
  
    --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
    @@ -666,10 +669,10 @@ void YamlConfiguration::parsePortYaml(YAML::Node *portNode,
       checkRequiredField(&inputPortsObj, "id",
                          CONFIG_YAML_REMOTE_PROCESS_GROUP_KEY,
                          "The field 'id' is required for "
    -                         "the port named '" + nameStr + "' in the YAML Config. If this port "
    --- End diff --
    
    There are linter failures. We have a formatter that can be used with intellij with a little work. May help avoid some of these issues. You're making changes that override our formatter. Would probably behoove us to apply formatters as a pre commit hook.


> Support required processor properties
> -------------------------------------
>
>                 Key: MINIFICPP-502
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-502
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> Allow developers to specify properties as required, and validate this in the configuration reader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)