[jira] [Updated] (LUCENE-1650) Small fix in CustomScoreQuery JavaDoc

["David Smiley (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated LUCENE-1650:
---------------------------------

    Fix Version/s:     (was: 4.7)
                   4.8

> Small fix in CustomScoreQuery JavaDoc
> -------------------------------------
>
>                 Key: LUCENE-1650
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1650
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/javadocs
>            Reporter: Simon Willnauer
>            Priority: Minor
>              Labels: dead
>             Fix For: 4.8
>
>         Attachments: LUCENE-1650.patch, LUCENE-1650.patch, customScoreQuery_CodeChange+JavaDoc.patch, customScoreQuery_JavaDoc.patch
>
>
> I have fixed the javadoc for  "Modified Score" formular in CustomScoreQuery. - Patch attached: customScoreQuery_JavaDoc.patch 
> I'm quite curious why the method:
>  public float customScore(int doc, float subQueryScore, float valSrcScores[]) 
> calls public float customScore(int doc, float subQueryScore, float valSrcScore])  only in 2 of the 3 cases which makes the choice to override either one of the customScore methods dependent on the number of ValueSourceQuery passed to the constructor. I figure it would be more consistent if it would call the latter in all 3 cases.
> I also attached a patch which proposes a fix for that issue. The patch does also include the JavaDoc issue mentioned above.
> - customScoreQuery_CodeChange+JavaDoc.patch



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org