You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/24 15:45:41 UTC
[GitHub] [rocketmq-client-cpp] SRC-xiaojin opened a new pull request, #441: reduce unnecessary tmp copy
SRC-xiaojin opened a new pull request, #441:
URL: https://github.com/apache/rocketmq-client-cpp/pull/441
## What is the purpose of the change
reduce unnecessary tmp copy
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] SRC-xiaojin closed pull request #441: reduce unnecessary tmp copy
Posted by "SRC-xiaojin (via GitHub)" <gi...@apache.org>.
SRC-xiaojin closed pull request #441: reduce unnecessary tmp copy
URL: https://github.com/apache/rocketmq-client-cpp/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] lizhanhui commented on a diff in pull request #441: reduce unnecessary tmp copy
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #441:
URL: https://github.com/apache/rocketmq-client-cpp/pull/441#discussion_r954422775
##########
src/protocol/RemotingCommand.cpp:
##########
@@ -302,6 +302,10 @@ void RemotingCommand::setMsgBody(const string& body) {
m_msgBody = body;
}
+void RemotingCommand::moveMsgBody(std::string&& body) {
Review Comment:
Why not provide an overload method of SetBody, accepting a r-value reference to string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] lizhanhui commented on a diff in pull request #441: reduce unnecessary tmp copy
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #441:
URL: https://github.com/apache/rocketmq-client-cpp/pull/441#discussion_r954422205
##########
src/MQClientAPIImpl.cpp:
##########
@@ -268,7 +268,7 @@ void MQClientAPIImpl::sendHeartbeat(const string& addr,
string body;
pHeartbeatData->Encode(body);
request.SetBody(body.data(), body.length());
Review Comment:
Line #270 and #271 duplicate. The data is copied twice.
##########
src/MQClientAPIImpl.cpp:
##########
@@ -888,7 +888,7 @@ void MQClientAPIImpl::lockBatchMQ(const string& addr,
string body;
requestBody->Encode(body);
request.SetBody(body.data(), body.length());
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] SRC-xiaojin commented on a diff in pull request #441: reduce unnecessary tmp copy
Posted by GitBox <gi...@apache.org>.
SRC-xiaojin commented on code in PR #441:
URL: https://github.com/apache/rocketmq-client-cpp/pull/441#discussion_r955050401
##########
src/protocol/RemotingCommand.cpp:
##########
@@ -302,6 +302,10 @@ void RemotingCommand::setMsgBody(const string& body) {
m_msgBody = body;
}
+void RemotingCommand::moveMsgBody(std::string&& body) {
Review Comment:
> Why not provide an overloading method of SetBody, accepting a r-value reference to string
because it is more easy to understand the "move" of the function，if overload method of SetBody,I think developer may use reference method, but not use r-value reference method~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-cpp] lizhanhui commented on a diff in pull request #441: reduce unnecessary tmp copy
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #441:
URL: https://github.com/apache/rocketmq-client-cpp/pull/441#discussion_r954422775
##########
src/protocol/RemotingCommand.cpp:
##########
@@ -302,6 +302,10 @@ void RemotingCommand::setMsgBody(const string& body) {
m_msgBody = body;
}
+void RemotingCommand::moveMsgBody(std::string&& body) {
Review Comment:
Why not provide an overloading method of SetBody, accepting a r-value reference to string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org