You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/12 08:15:18 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3043: net/local: Remove local_send.c since nobody use it now
xiaoxiang781216 opened a new pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043
## Summary
## Impact
Should no
## Testing
Pass the build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797444801
@acassis - when you satisfied please mereg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797462405
> @acassis - when you satisfied please merge
Thank you @davids5 I just will wait for @xiaoxiang781216 reply/fix and merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797438520
Please supply more information [here](https://github.com/apache/incubator-nuttx/pull/3043#issue-591464860)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797443935
@acassis - I grepped the code base all the resent changes orphaned it. There has been a lot of really good work done on networking.
@xiaoxiang781216 What is needed is a concise med/high level description of all the resent networking changes and the **motivation / benefits.**.
It will be needed for the release notes and is scattered at the moment. Answer question like why sndmsg was added etc would be super helpful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797501614
@acassis the commit message is updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797444801
@acassis - when you satisfied please merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3043: net/local: Remove local_send.c since nobody use it now
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3043:
URL: https://github.com/apache/incubator-nuttx/pull/3043#issuecomment-797437216
Hi @xiaoxiang781216 please describe the commit better. Why we don't need it anymore? Please cite other commit or issue. Is it because local_sendmsg.c can be a replacement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org