You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/01/27 17:31:23 UTC

[GitHub] incubator-brooklyn pull request: Disable SSLv3

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/477

    Disable SSLv3

    Also enable `$brooklyn:object` to use TypeCoercions enabled objects (i.e. for objects that don't have setters). This enables one to use:
    
    ```
    services:
    - type: brooklyn.entity.webapp.jboss.JBoss7Server
      brooklyn.config:
        webapp.enabledProtocols: ["https"]
        webapp.https.ssl:
          $brooklyn:object:
            objectType: brooklyn.entity.webapp.HttpsSslConfig
            object.fields:
              keystoreUrl: https://artifactory:AP5QT5YLhmBu3ET9Qe8wwkrNs3r@artifactory.mms.ibmcloud.com/artifactory/thirdparty/certs/faisalssaph1_keystore
              keystorePassword: changeit
              keyAlias: amm
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn disable-sslv3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #477
    
----
commit b726bd9d8b17f92a585ffb329d32ad2d7b643a7b
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-01-27T14:56:46Z

    Disable SSLv3 for Tomcat7, JBoss7, brooklyn-rest-server

commit 8793e9db533b290fb9d73705b05fb6409926b21b
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-01-27T14:59:01Z

    $brooklyn:object - try to instantiate using TypeCoercions
    
    Fall back to reflection.

commit e87c49c13eee82102854b6c4e7204f40371a6e0b
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2015-01-27T16:15:04Z

    Don't read global properties for tests
    
    My custom config should't influence the tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Disable SSLv3

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/477


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Disable SSLv3

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/477#issuecomment-71692029
  
    looks good to me.  there is no reason anyone should use SSLv3 so disabling it universally makes sense.
    
    will merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---