You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/26 07:17:26 UTC

[GitHub] [incubator-mxnet] Flamefire commented on issue #14794: Fix wrong description of output range of ToTensor

Flamefire commented on issue #14794: Fix wrong description of output range of ToTensor
URL: https://github.com/apache/incubator-mxnet/pull/14794#issuecomment-486953756
 
 
   Good catch. I fixed that, grepped for `[0, 1)` and did not found any other instances.
   
   I was thinking about adding a test that 0 is mapped to 0.f and 255 to 1.f (exactly). The current tests check random input against `almost_equal` `array/255` so the limits might not be checked properly. Is this worth it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services