You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/04 03:24:10 UTC

[GitHub] [nifi] ijokarumawak commented on issue #3405: NIFI-6185: ListDatabaseTables processor doesn't close ResultSets

ijokarumawak commented on issue #3405: NIFI-6185: ListDatabaseTables processor doesn't close ResultSets
URL: https://github.com/apache/nifi/pull/3405#issuecomment-479735388
 
 
   The Travis build failures look like timeouts, not related to this change. I have successfully ran contrib-check locally with this PR. Change looks good tome, +1. Merging to master.
   
   Do you see the same 'too many open cursors' error with other SQL processors, for example ExecuteSQL querying Oracle? I'm wondering if we need to fix those as well. Currently AbstractExecuteSQL doesn't close ResultSet.
   https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java#L256
   
   Thanks @lfrancke for fixing this!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services