[GitHub] [trafficserver] ywkaras commented on a change in pull request #8580: Ports #7897 from core strategies to parent_select plugin.

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#discussion_r782530296



##########
File path: plugins/experimental/parent_select/consistenthash.cc
##########
@@ -248,11 +256,13 @@ PLNextHopConsistentHash::getHashKey(uint64_t sm_id, TSMBuffer reqp, TSMLoc url,
 }
 
 static void
-makeNextParentErr(const char **hostname, size_t *hostname_len, in_port_t *port)
+makeNextParentErr(const char **hostname, size_t *hostname_len, in_port_t *port, bool *retry, bool *no_cache)
 {
   *hostname     = nullptr;
   *hostname_len = 0;
   *port         = 0;
+  *retry        = false;
+  *no_cache     = false;

Review comment:
       This is how people who didn't go to graduate school would do this:  https://godbolt.org/z/M3z5fY46n




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org