You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/03/21 22:57:54 UTC

[GitHub] [logging-log4cxx] rm5248 commented on pull request #54: [Logcxx-515] Add fmt support

rm5248 commented on pull request #54:
URL: https://github.com/apache/logging-log4cxx/pull/54#issuecomment-803674989


   > Or should we make looking for that package simply [silent](https://cmake.org/cmake/help/latest/command/find_package.html)?
   > 
   > ```
   > find_package(fmt QUIET)
   > ```
   
   I prefer to make it quiet, since it's 1. only an example, and 2. at the end of configuration, we print out some stats/configuration information anyway, where we can print out if we're using it or not.  Number 2 may be more useful later, as when I get around to [LOGCXX-514](https://issues.apache.org/jira/browse/LOGCXX-514) a more verbose error message would be useful(I'm planning on it being an optional dependency).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org