You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "marta-jankovics (via GitHub)" <gi...@apache.org> on 2023/08/29 09:42:08 UTC
[GitHub] [fineract] marta-jankovics opened a new pull request, #3409: Fineract-1969: Datatable insert, update SQL Injection
marta-jankovics opened a new pull request, #3409:
URL: https://github.com/apache/fineract/pull/3409
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3409: Fineract-1969: Datatable insert, update SQL Injection
Posted by "marta-jankovics (via GitHub)" <gi...@apache.org>.
marta-jankovics commented on code in PR #3409:
URL: https://github.com/apache/fineract/pull/3409#discussion_r1311811466
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -78,6 +79,14 @@ public static LocalDateTime getLocalDateTimeOfSystem() {
return LocalDateTime.now(ZoneId.systemDefault()).truncatedTo(ChronoUnit.SECONDS);
}
+ public static LocalDateTime getAuditLocalDateTime() {
Review Comment:
This change belongs to this PR as I already use it for the datatables.
I suggested to create this method and use it all over the application instead of the system time, even if it does not cause any problem for now, because of the current server settings.
This should be done by a separate request, separate story, separate PR. For now I introduced these methods and will use for datatables and savings related entities. Savings changes will come with the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy merged pull request #3409: Fineract-1969: Datatable insert, update SQL Injection
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #3409:
URL: https://github.com/apache/fineract/pull/3409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3409: Fineract-1969: Datatable insert, update SQL Injection
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3409:
URL: https://github.com/apache/fineract/pull/3409#discussion_r1311616319
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -78,6 +79,14 @@ public static LocalDateTime getLocalDateTimeOfSystem() {
return LocalDateTime.now(ZoneId.systemDefault()).truncatedTo(ChronoUnit.SECONDS);
}
+ public static LocalDateTime getAuditLocalDateTime() {
Review Comment:
I would be happier if this would be moved into a new PR and change every places to use this instead of the LocalDateTime.now with system TZ.
I reckon it was said in the Readme the application should be run on server with UTC, so should be no issue since LocalDateTime.now(UTC) and LocalDateTime.now(SystemTimeZone) should be equals, but still for consistency purposes it would be better to use only one of them.
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -78,6 +79,14 @@ public static LocalDateTime getLocalDateTimeOfSystem() {
return LocalDateTime.now(ZoneId.systemDefault()).truncatedTo(ChronoUnit.SECONDS);
}
+ public static LocalDateTime getAuditLocalDateTime() {
Review Comment:
I would be happier if this would be moved into a new PR and change every places to use this instead of the LocalDateTime.now with system TZ.
I reckon it was said in the Readme the application should be run on server with UTC, so should be no issue since LocalDateTime.now(UTC) and LocalDateTime.now(SystemTimeZone) should be equals, but still for consistency purposes it would be better to use only one of them.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org