You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "saminbassiri (via GitHub)" <gi...@apache.org> on 2025/01/30 16:58:51 UTC
[PR] Add Co-occurrence matrix for GloVe word embedding [systemds]
saminbassiri opened a new pull request, #2200:
URL: https://github.com/apache/systemds/pull/2200
This PR adds the implementation for the co-occurrence matrix in DML.
The co-occurrence matrix can be used in word embedding like GloVe and word2vec.
The implementation is based on this repository:
[GloVe: Global Vectors for Word Representation](https://github.com/stanfordnlp/GloVe/blob/master/src/cooccur.c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Co-occurrence matrix for GloVe word embedding [systemds]
Posted by "cmcuza (via GitHub)" <gi...@apache.org>.
cmcuza commented on PR #2200:
URL: https://github.com/apache/systemds/pull/2200#issuecomment-2628991120
I suggest editing the PR's title to indicate that it is related to the issue [[SYSTEMDS-3179]](https://issues.apache.org/jira/browse/SYSTEMDS-3179), for example, #2206. Moreover, I suggest giving more details regarding the code in this PR the proposed `scripts/builtin/cooccur.dml` has many small functionalities. Finally, I suggest adding the proper testing of the proposed co-occurrence matrix calculation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3179] Add Co-occurrence matrix for GloVe word embedding [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2200:
URL: https://github.com/apache/systemds/pull/2200#issuecomment-2631691598
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2200?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 72.37%. Comparing base [(`615cd9a`)](https://app.codecov.io/gh/apache/systemds/commit/615cd9ac4860d984cd7167f223ff4b8789ac612d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`dda11b6`)](https://app.codecov.io/gh/apache/systemds/commit/dda11b6776568fa0bf47a88f8a8d557fa4cf1cca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 19 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2200 +/- ##
============================================
+ Coverage 72.27% 72.37% +0.10%
- Complexity 44978 45324 +346
============================================
Files 1452 1467 +15
Lines 169309 170537 +1228
Branches 33037 33247 +210
============================================
+ Hits 122364 123431 +1067
- Misses 37630 37716 +86
- Partials 9315 9390 +75
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2200?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3179] Add Co-occurrence matrix for GloVe word embedding [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2200:
URL: https://github.com/apache/systemds/pull/2200#issuecomment-2869851413
LGTM - sorry for the delay and thanks for the contribution @saminbassiri. Overall, this patch already looks pretty good. During the merge, I only fixed the formatting of java tests (tabs over spaces in Java), fixed the frame-typing of the builtin function, and left a few TODOs to later vectorize some of the loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3179] Add Co-occurrence matrix for GloVe word embedding [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 closed pull request #2200: [SYSTEMDS-3179] Add Co-occurrence matrix for GloVe word embedding
URL: https://github.com/apache/systemds/pull/2200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org