You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2022/08/25 13:43:41 UTC
[Impala-ASF-CR] IMPALA-9499: Display support for all complex types in a SELECT * query
Hello Daniel Becker, Csaba Ringhofer,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18863
to look at the new patch set (#3).
Change subject: IMPALA-9499: Display support for all complex types in a SELECT * query
......................................................................
IMPALA-9499: Display support for all complex types in a SELECT * query
This change adds EXPAND_COMPLEX_TYPES query option to support the
display of complex types in SELECT statements where star (*) expression
is in the select list. The query option changes the behaviour of star
expansion to list all top-level complex column fields, instead of
listing the scalar column fields only. Nested complex type expansion is
also supported, eg.: struct.* will enumerate the nested collections
inside struct. Array and struct collection types are supported.
Testing:
- Analyzer tests check the proper expansion of complex types when the
query option is enabled.
- EE tests check the proper complex type deserialization when the query
option is enabled, and the original behaviour when the option is
disabled.
Change-Id: I84b5e5703f9e0ce0f4f8bff83941677dd7489974
---
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaService.thrift
M common/thrift/Query.thrift
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/SlotRef.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
A testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion-array.test
A testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion-disabled.test
A testdata/workloads/functional-query/queries/QueryTest/nested-types-star-expansion-struct.test
M tests/query_test/test_nested_types.py
11 files changed, 287 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/18863/3
--
To view, visit http://gerrit.cloudera.org:8080/18863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84b5e5703f9e0ce0f4f8bff83941677dd7489974
Gerrit-Change-Number: 18863
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>