You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/03/09 00:48:59 UTC
[jira] Created: (WHIRR-249) Firewall authorization should be
idempotent
Firewall authorization should be idempotent
-------------------------------------------
Key: WHIRR-249
URL: https://issues.apache.org/jira/browse/WHIRR-249
Project: Whirr
Issue Type: Bug
Reporter: Tom White
Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-249:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Tom for reviewing.
bq. Findbugs next? WHIRR-321
Sounds great! :)
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-249.patch, WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040184#comment-13040184 ]
Adrian Cole commented on WHIRR-249:
-----------------------------------
http://code.google.com/p/jclouds/issues/detail?id=576
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040170#comment-13040170 ]
Adrian Cole commented on WHIRR-249:
-----------------------------------
Yeah we should ignore the param for an empty description. Thnx for catching.
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-249:
------------------------------
Attachment: WHIRR-249.patch
Attached patch with integration tests.
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Attachments: WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-249:
------------------------------
Fix Version/s: 0.6.0
Assignee: Andrei Savu
Status: Patch Available (was: Open)
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043038#comment-13043038 ]
Tom White commented on WHIRR-249:
---------------------------------
> Fixed one checkstyle error - unused import; it's nice to have that check running on mvn install.
+1
Findbugs next? WHIRR-321
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-249.patch, WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-249:
------------------------------
Attachment: WHIRR-249.patch
Fixed one checkstyle error - unused import; it's nice to have that check running on mvn install. I'm planning to commit this tomorrow.
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-249.patch, WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-249) Firewall authorization should be
idempotent
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040155#comment-13040155 ]
Andrei Savu commented on WHIRR-249:
-----------------------------------
I've also discovered a bug in jclouds. If I specify an empty description when creating a new security group the call signature is wrong.
For the following call:
{code}
ec2Client.getSecurityGroupServices()
.createSecurityGroupInRegion(REGION, groupName, "");
{code}
I get this exception:
{noformat}
-------------------------------------------------------------------------------
Test set: org.apache.whirr.service.jclouds.integration.FirewallSettingsTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.905 sec <<< FAILURE!
testFirewallAuthorizationIsIdempotent(org.apache.whirr.service.jclouds.integration.FirewallSettingsTest) Time elapsed: 1.035 sec <<< ERROR!
org.jclouds.rest.AuthorizationException: The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details.
at org.jclouds.aws.handlers.ParseAWSErrorFromXmlContent.refineException(ParseAWSErrorFromXmlContent.java:114)
at org.jclouds.aws.handlers.ParseAWSErrorFromXmlContent.handleError(ParseAWSErrorFromXmlContent.java:85)
at org.jclouds.http.handlers.DelegatingErrorHandler.handleError(DelegatingErrorHandler.java:69)
at org.jclouds.http.internal.BaseHttpCommandExecutorService$HttpResponseCallable.shouldContinue(BaseHttpCommandExecutorService.java:200)
at org.jclouds.http.internal.BaseHttpCommandExecutorService$HttpResponseCallable.call(BaseHttpCommandExecutorService.java:165)
at org.jclouds.http.internal.BaseHttpCommandExecutorService$HttpResponseCallable.call(BaseHttpCommandExecutorService.java:134)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
Caused by: org.jclouds.http.HttpResponseException: command: POST https://ec2.us-east-1.amazonaws.com/ HTTP/1.1 failed with response: HTTP/1.1 403 Forbidden; content: [The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details.]
at org.jclouds.aws.handlers.ParseAWSErrorFromXmlContent.handleError(ParseAWSErrorFromXmlContent.java:74)
... 9 more
{noformat}
> Firewall authorization should be idempotent
> -------------------------------------------
>
> Key: WHIRR-249
> URL: https://issues.apache.org/jira/browse/WHIRR-249
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Fix For: 0.6.0
>
> Attachments: WHIRR-249.patch
>
>
> Sometimes firewall rules are left over from a previous cluster that wasn't shut down properly, leading to cluster launch failure. This can be fixed by making FirewallSettings.authorizeIngress idempotent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira