You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/22 23:00:00 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #8997: [SQL
Lab] Open request access link in a new tab
etr2460 opened a new pull request #8997: [SQL Lab] Open request access link in a new tab
URL: https://github.com/apache/incubator-superset/pull/8997
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Since this link is likely outside the superset domain, let's open it in a new tab. setting the `target` and the `rel` are the only changes here, the rest is formatting
### TEST PLAN
CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @graceguo-supercat @michellethomas @willbarrett @betodealmeida
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8997: [SQL Lab]
Open request access link in a new tab
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8997: [SQL Lab] Open request access link in a new tab
URL: https://github.com/apache/incubator-superset/pull/8997#issuecomment-577431746
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8997?src=pr&el=h1) Report
> Merging [#8997](https://codecov.io/gh/apache/incubator-superset/pull/8997?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e46ff239afc79af5753cfe82779fa87796f46a27?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8997?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8997 +/- ##
==========================================
- Coverage 59.16% 59.16% -0.01%
==========================================
Files 367 367
Lines 11679 11680 +1
Branches 2862 2863 +1
==========================================
Hits 6910 6910
- Misses 4590 4591 +1
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8997?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8997/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `77.55% <0%> (-0.8%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8997?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8997?src=pr&el=footer). Last update [e46ff23...75640cf](https://codecov.io/gh/apache/incubator-superset/pull/8997?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #8997: [SQL Lab]
Open request access link in a new tab
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #8997: [SQL Lab] Open request access link in a new tab
URL: https://github.com/apache/incubator-superset/pull/8997
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org