You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/04 04:00:01 UTC

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #350: [FLINK-29805] Fix incorrect snapshot filter when snapshots are committing too slow

LadyForest commented on code in PR #350:
URL: https://github.com/apache/flink-table-store/pull/350#discussion_r1013585500


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/SnapshotManager.java:
##########
@@ -109,7 +139,7 @@ public Long findLatest() throws IOException {
         return findByListFiles(Math::max);
     }
 
-    public Long findEarliest() throws IOException {
+    private Long findEarliest() throws IOException {

Review Comment:
   Nit: add `@Nullable` annotation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org