[GitHub] [spark] LuciferYang commented on a diff in pull request #39770: [WIP][SPARK-42206][CORE] Omit "Task Executor Metrics" field in eventlogs if values are all zero

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #39770:
URL: https://github.com/apache/spark/pull/39770#discussion_r1096139146


##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -793,7 +793,7 @@ class JsonProtocolSuite extends SparkFunSuite {
   }
 
   test("SPARK-42206: skip logging of all-zero Task Executor Metrics") {
-    val allZeroTaskExecutorMetrics = new ExecutorMetrics(Map.empty[String, Long])
+    val allZeroTaskExecutorMetrics = new ExecutorMetrics(Array.emptyLongArray)

Review Comment:
   `Map.empty[String, Long]` should  also ok for Scala 2.13 after https://github.com/apache/spark/pull/39772 merged



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org