You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "szymon-czapracki (via GitHub)" <gi...@apache.org> on 2024/01/16 10:08:25 UTC
[PR] Fix pairing error [mynewt-nimble]
szymon-czapracki opened a new pull request, #1673:
URL: https://github.com/apache/mynewt-nimble/pull/1673
This commit fixes an issue regarding pairing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix remove from resolving list issue [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1673:
URL: https://github.com/apache/mynewt-nimble/pull/1673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pairing error [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1673:
URL: https://github.com/apache/mynewt-nimble/pull/1673#discussion_r1461455159
##########
nimble/host/src/ble_gap.c:
##########
@@ -6201,7 +6201,8 @@ ble_gap_unpair(const ble_addr_t *peer_addr)
rc = ble_hs_pvcy_remove_entry(peer_addr->type,
peer_addr->val);
- if (rc != 0) {
+
+ if (rc != 0 && rc != BLE_HS_ERR_HCI_BASE + BLE_ERR_UNK_CONN_ID) {
Review Comment:
add braces around BLE_HS_ERR_HCI_BASE + BLE_ERR_UNK_CONN_ID
##########
nimble/host/src/ble_gap.c:
##########
@@ -6201,7 +6201,8 @@ ble_gap_unpair(const ble_addr_t *peer_addr)
rc = ble_hs_pvcy_remove_entry(peer_addr->type,
peer_addr->val);
- if (rc != 0) {
+
Review Comment:
add a comment why this particular error is allowed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix pairing error [mynewt-nimble]
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek commented on PR #1673:
URL: https://github.com/apache/mynewt-nimble/pull/1673#issuecomment-1893746381
issue description is missing in commit message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org