You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/27 11:03:46 UTC
[GitHub] [shardingsphere] menghaoranss opened a new pull request #10503: Show sharding table rules % show sharding table rule table
menghaoranss opened a new pull request #10503:
URL: https://github.com/apache/shardingsphere/pull/10503
For #10454 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10503: Show sharding table rules % show sharding table rule table
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10503:
URL: https://github.com/apache/shardingsphere/pull/10503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #10503: Show sharding table rules % show sharding table rule table
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #10503:
URL: https://github.com/apache/shardingsphere/pull/10503#discussion_r640526307
##########
File path: shardingsphere-distsql-parser/shardingsphere-distsql-parser-engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/DistSQLVisitor.java
##########
@@ -434,6 +420,12 @@ public ASTNode visitShowEncryptTableRule(final ShowEncryptTableRuleContext ctx)
return new ShowEncryptTableRuleStatement(ctx.tableName().getText(), Objects.nonNull(ctx.schemaName()) ? (SchemaSegment) visit(ctx.schemaName()) : null);
}
+ @Override
Review comment:
conditional operator nested is not a good practice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org