[GitHub] emilianbold commented on a change in pull request #537: Maven Indexing Optimizations

[GitBox <gi...@apache.org>]

emilianbold commented on a change in pull request #537: Maven Indexing Optimizations
URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187236049
 
 

 ##########
 File path: maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java
 ##########
 @@ -213,39 +217,112 @@ static void search(String className, Indexer indexer, Collection<IndexingContext
         return referrers;
     }
 
+    static final Predicate<String> JDK_CLASS_TEST = new MatchWords(new String[]{
 
 Review comment:
   The previous code used the system classloader to see if a class is from the JRE. Here you just generated a list of folders/package names.
   
   Is there no chance that this list will need updating in the future?
   
   Is this list the same across different JREs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists