You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 10:45:31 UTC
[GitHub] [airflow] ashb opened a new pull request, #26589: Convert release manager instructions to use "partial" svn checkouts
ashb opened a new pull request, #26589:
URL: https://github.com/apache/airflow/pull/26589
This just makes it a bit easier to manage copying between dev and release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26589: Convert release manager instructions to use "partial" svn checkouts
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26589:
URL: https://github.com/apache/airflow/pull/26589#discussion_r977504325
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -314,12 +314,12 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
```shell script
# First clone the repo
- svn checkout https://dist.apache.org/repos/dist/dev/airflow airflow-dev
- cd airflow-dev
- # Or move into it if you already have it cloned
+
+ [ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
Review Comment:
Not what the current instructions tell you to do :)
```
cd <YOUR_AIRFLOW_REPO_ROOT>
export AIRFLOW_REPO_ROOT=$(pwd)
[ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
svn update --set-depth=infinity asf-dist/{release,dev}/airflow
AIRFLOW_DEV_SVN="${PWD}/asf-dist/dev/airflow"
cd asf-dist/release/airflow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26589: Convert release manager instructions to use "partial" svn checkouts
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26589:
URL: https://github.com/apache/airflow/pull/26589#discussion_r977503338
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -314,12 +314,12 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
```shell script
# First clone the repo
- svn checkout https://dist.apache.org/repos/dist/dev/airflow airflow-dev
- cd airflow-dev
- # Or move into it if you already have it cloned
+
+ [ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
Review Comment:
Oh, I've always just run this from the dir above the `airflow` git checkout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26589: Convert release manager instructions to use "partial" svn checkouts
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26589:
URL: https://github.com/apache/airflow/pull/26589#discussion_r977510485
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -314,12 +314,12 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
```shell script
# First clone the repo
- svn checkout https://dist.apache.org/repos/dist/dev/airflow airflow-dev
- cd airflow-dev
- # Or move into it if you already have it cloned
+
+ [ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
Review Comment:
no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26589: Convert release manager instructions to use "partial" svn checkouts
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26589:
URL: https://github.com/apache/airflow/pull/26589#discussion_r977504325
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -314,12 +314,12 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
```shell script
# First clone the repo
- svn checkout https://dist.apache.org/repos/dist/dev/airflow airflow-dev
- cd airflow-dev
- # Or move into it if you already have it cloned
+
+ [ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
Review Comment:
Not what the current instructions tell you to do :)
```
cd <YOUR_AIRFLOW_REPO_ROOT>
export AIRFLOW_REPO_ROOT=$(pwd)
[ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
svn update --set-depth=infinity asf-dist/{release,dev}/airflow
AIRFLOW_DEV_SVN="${PWD}/asf-dist/dev/airflow"
cd asf-dist/release/airflow
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26589: Convert release manager instructions to use "partial" svn checkouts
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26589:
URL: https://github.com/apache/airflow/pull/26589#discussion_r977502612
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -314,12 +314,12 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
```shell script
# First clone the repo
- svn checkout https://dist.apache.org/repos/dist/dev/airflow airflow-dev
- cd airflow-dev
- # Or move into it if you already have it cloned
+
+ [ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
Review Comment:
I like the idea of unifying it iunder arlfow repo. We need to add asf-dist to .gitignore though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #26589: Convert release manager instructions to use "partial" svn checkouts
Posted by GitBox <gi...@apache.org>.
ashb merged PR #26589:
URL: https://github.com/apache/airflow/pull/26589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #26589: Convert release manager instructions to use "partial" svn checkouts
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #26589:
URL: https://github.com/apache/airflow/pull/26589#discussion_r977509547
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -314,12 +314,12 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
```shell script
# First clone the repo
- svn checkout https://dist.apache.org/repos/dist/dev/airflow airflow-dev
- cd airflow-dev
- # Or move into it if you already have it cloned
+
+ [ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist
Review Comment:
Oh yeah. Any objections to me changing that too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org