[GitHub] [skywalking] wu-sheng commented on issue #7407: Is rebase strategy of ByteBuddy in SkyWalking compatiable with javassist in other java agent tools? can it be solved?

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #7407:
URL: https://github.com/apache/skywalking/issues/7407#issuecomment-892420321


   > Use redefine strategy of Byte-Buddy in SkyWalking(I dont know why SkyWalking using rebase strategy, and I am not sure what it really effects when I changed it.)
   
   You should not change this strategy, we choose this for a long history. This is a better way to do so.
   
   > Avoid enhanced private construtors of ForkJoinTask in transmitable-thread-local (This solution makes TTL compatible, but I have to change javassist code)
   > Do not enhance ForkJoinTask, enhance ForkJoinPool or some classes else. (This may solve my problem, but the compatible problem is still unresolved)
   
   What you have done, is your private codes. A TLP should not change anything because of a private codebase. This is a principle of an open source project. Especially this thing doesn't benefit the community at all.
   
   The thing you do in your agent, could be done natively in SkyWalking's agent system. You should adopt a community, rather than ask a large community to adopt you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org