[GitHub] [spark] MaxGekk edited a comment on pull request #31499: [SPARK-31891][SQL] Support `MSCK REPAIR TABLE .. [ADD|DROP|SYNC] PARTITIONS`

[GitBox <gi...@apache.org>]

MaxGekk edited a comment on pull request #31499:
URL: https://github.com/apache/spark/pull/31499#issuecomment-779364958


   @dongjoon-hyun Thank you for reviewing this PR. Regarding to syntax for alternatives, I wasn't sure what should I use in docs. I just looked at existing examples:
   
   1. `ANALYZE TABLE` (similar in [EXPLAIN](http://spark.apache.org/docs/latest/sql-ref-syntax-qry-explain.html))
   
   In docs ([link](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-analyze-table.html)):
   ```
   [ NOSCAN | FOR COLUMNS col [ , ... ] | FOR ALL COLUMNS ]
   ```
   In SqlBase.g4:
   https://github.com/apache/spark/blob/ba974ea8e4cc8075056682c2badab5ca64b90047/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4#L136
   
   2. `SHOW TABLES`
   
   In docs ([link](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-show-tables.html))
   ```
   { FROM | IN }
   ```
   In SqlBase.g4:
   https://github.com/apache/spark/blob/ba974ea8e4cc8075056682c2badab5ca64b90047/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4#L198
   
   You proposed `(ADD|DROP|SYNC)` but I haven't found any examples with such syntax. Do you know what the syntax the Spark SQL guide uses?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org