You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/15 15:25:50 UTC
[PR] [Studio] fix: mask credentials on Unicode boundaries [rocketmq-dashboard]
yyqdbngt opened a new pull request, #2253:
URL: https://github.com/apache/rocketmq-dashboard/pull/2253
## Summary
- measure credential masking thresholds by Unicode code point instead of UTF-16 code unit
- preserve complete supplementary characters at the four-code-point prefix and suffix boundaries
- fail closed for malformed UTF-16 so masked API responses never expose isolated surrogates
- preserve the existing null, empty, short-value, and ASCII behavior
## Problem
`CredentialUtils.mask` sliced credentials at fixed UTF-16 offsets. A supplementary character at a visibility boundary could therefore be split, producing malformed Unicode in an API response. Supplementary characters also counted twice toward the partial-mask threshold.
## Verification
- `CredentialUtilsTest`: 7 tests passed
- related ACL and credential suites: 75 tests passed
- Maven Checkstyle: 0 violations
- main/test compilation: 400 main and 140 test sources compiled successfully
- `git diff --check`
Closes #2252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] fix: mask credentials on Unicode boundaries [rocketmq-dashboard]
Posted by "yyqdbngt (via GitHub)" <gi...@apache.org>.
yyqdbngt commented on PR #2253:
URL: https://github.com/apache/rocketmq-dashboard/pull/2253#issuecomment-5329693172
Consolidated into #2362 as requested, rebased onto the latest `rocketmq-studio`, with the current schema/instance refactors accounted for and the combined test suite verified. Closing this individual submission so content review can continue on the consolidated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Studio] fix: mask credentials on Unicode boundaries [rocketmq-dashboard]
Posted by "yyqdbngt (via GitHub)" <gi...@apache.org>.
yyqdbngt closed pull request #2253: [Studio] fix: mask credentials on Unicode boundaries
URL: https://github.com/apache/rocketmq-dashboard/pull/2253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org