svn commit: r1396285 - /subversion/trunk/subversion/libsvn_subr/win32_crypto.c

[br...@apache.org]

Author: brane
Date: Tue Oct  9 20:11:07 2012
New Revision: 1396285

URL: http://svn.apache.org/viewvc?rev=1396285&view=rev
Log:
Fix crash bug from solution for issues #4112 and #4110 in r1242759.

* subversion/libsvn_subr/win32_crypto.c
  (windows_password_decrypter, windows_ssl_client_cert_pw_decrypter):
   Check the "done" flag, not the pointer to the "done" flag.

Found by: steveking

Modified:
    subversion/trunk/subversion/libsvn_subr/win32_crypto.c

Modified: subversion/trunk/subversion/libsvn_subr/win32_crypto.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/win32_crypto.c?rev=1396285&r1=1396284&r2=1396285&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/win32_crypto.c (original)
+++ subversion/trunk/subversion/libsvn_subr/win32_crypto.c Tue Oct  9 20:11:07 2012
@@ -145,7 +145,7 @@ windows_password_decrypter(svn_boolean_t
 
   SVN_ERR(svn_auth__simple_password_get(done, &in, creds, realmstring, username,
                                         parameters, non_interactive, pool));
-  if (!done)
+  if (!*done)
     return SVN_NO_ERROR;
 
   orig = svn_base64_decode_string(svn_string_create(in, pool), pool);
@@ -270,7 +270,7 @@ windows_ssl_client_cert_pw_decrypter(svn
   SVN_ERR(svn_auth__ssl_client_cert_pw_get(done, &in, creds, realmstring,
                                            username, parameters,
                                            non_interactive, pool));
-  if (!done)
+  if (!*done)
     return SVN_NO_ERROR;
 
   orig = svn_base64_decode_string(svn_string_create(in, pool), pool);