You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "saowu (via GitHub)" <gi...@apache.org> on 2024/09/04 11:05:03 UTC
[PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
saowu opened a new pull request, #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
fix #16569
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744687400
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
It's better to use `@Data` to avoid getter and setter.
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -94,14 +95,14 @@ public static AlertResult checkSendFeiShuSendMsgResult(String result) {
log.info("send fei shu msg error,resp error");
return alertResult;
}
- if (sendMsgResponse.statusCode == 0) {
+ if (sendMsgResponse.code == 0) {
alertResult.setSuccess(true);
alertResult.setMessage("send fei shu msg success");
return alertResult;
}
- alertResult.setMessage(String.format("alert send fei shu msg error : %s", sendMsgResponse.getStatusMessage()));
- log.info("alert send fei shu msg error : {} ,Extra : {} ", sendMsgResponse.getStatusMessage(),
- sendMsgResponse.getExtra());
+ alertResult.setMessage(String.format("alert send fei shu msg error : %s", sendMsgResponse.getMsg()));
+ log.info("alert send fei shu msg error : {} ,Data : {} ", sendMsgResponse.getMsg(),
Review Comment:
```suggestion
log.info("alert send fei shu msg error : {}, Data : {} ", sendMsgResponse.getMsg(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "saowu (via GitHub)" <gi...@apache.org>.
saowu commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744697891
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
I think following the original code and fixing it is always the most effective way to avoid unknown problems.
Do you need to modify and resubmit? The bug has been fixed and passed the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "saowu (via GitHub)" <gi...@apache.org>.
saowu commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744694964
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
`spotless-maven-plugin` This plugin is giving me a headache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "saowu (via GitHub)" <gi...@apache.org>.
saowu commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744708296
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744699084
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
> The bug has been fixed and passed the review
This is the review process, and it hasn't passed yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744698259
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
You should find ways to modify the code while conforming to code style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "saowu (via GitHub)" <gi...@apache.org>.
saowu commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744690670
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
I try to make as few changes as possible to avoid failing the code standards.
The original code style is like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16584:
URL: https://github.com/apache/dolphinscheduler/pull/16584#discussion_r1744691537
##########
dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-feishu/src/main/java/org/apache/dolphinscheduler/plugin/alert/feishu/FeiShuSender.java:
##########
@@ -177,41 +178,38 @@ private String sendMsg(AlertData alertData) throws IOException {
static final class FeiShuSendMsgResponse {
Review Comment:
What do you mean by `failing the code standards`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-16569][alert] FeiShuSendMsgResponse expired [dolphinscheduler]
Posted by "saowu (via GitHub)" <gi...@apache.org>.
saowu closed pull request #16584: [Fix-16569][alert] FeiShuSendMsgResponse expired
URL: https://github.com/apache/dolphinscheduler/pull/16584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org