[GitHub] [druid] suneet-s commented on a change in pull request #9306: implement Azure InputSource reader and deprecate Azure FireHose

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9306: implement Azure InputSource reader and deprecate Azure FireHose
URL: https://github.com/apache/druid/pull/9306#discussion_r374382373
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/data/input/impl/CloudObjectInputSource.java
 ##########
 @@ -40,6 +40,7 @@
 public abstract class CloudObjectInputSource<T extends InputEntity> extends AbstractInputSource
     implements SplittableInputSource<CloudObjectLocation>
 {
+  protected static final int MAX_LISTING_LENGTH = 1024;
 
 Review comment:
   I don't think it's good to have the base class decide the max length for all the implementations. It would be better to expose this through a function. Should this be made configurable? 
   
   I see the `GoogleCloudStorageInputSource` used to have a max of 10. This makes it 1024. Also the AzureInputSource uses it's own definition for `MAX_LISTING_LENGTH`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org