[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2184: Freemarker native support

[GitBox <gi...@apache.org>]

jamesnetherton commented on a change in pull request #2184:
URL: https://github.com/apache/camel-quarkus/pull/2184#discussion_r567824292



##########
File path: extensions/freemarker/deployment/src/main/java/org/apache/camel/quarkus/component/freemarker/deployment/FreemarkerProcessor.java
##########
@@ -16,31 +16,31 @@
  */
 package org.apache.camel.quarkus.component.freemarker.deployment;
 
+import io.quarkus.arc.deployment.BeanContainerBuildItem;
 import io.quarkus.deployment.annotations.BuildStep;
 import io.quarkus.deployment.annotations.ExecutionTime;
 import io.quarkus.deployment.annotations.Record;
 import io.quarkus.deployment.builditem.FeatureBuildItem;
-import io.quarkus.deployment.pkg.steps.NativeBuild;
-import org.apache.camel.quarkus.core.JvmOnlyRecorder;
-import org.jboss.logging.Logger;
+import org.apache.camel.component.freemarker.FreemarkerComponent;
+import org.apache.camel.quarkus.component.freemarker.CamelFreemarkerRecorder;
+import org.apache.camel.quarkus.core.deployment.spi.CamelRuntimeBeanBuildItem;
 
 class FreemarkerProcessor {
 
-    private static final Logger LOG = Logger.getLogger(FreemarkerProcessor.class);
     private static final String FEATURE = "camel-freemarker";
 
     @BuildStep
     FeatureBuildItem feature() {
         return new FeatureBuildItem(FEATURE);
     }
 
-    /**
-     * Remove this once this extension starts supporting the native mode.
-     */
-    @BuildStep(onlyIf = NativeBuild.class)
-    @Record(value = ExecutionTime.RUNTIME_INIT)
-    void warnJvmInNative(JvmOnlyRecorder recorder) {
-        JvmOnlyRecorder.warnJvmInNative(LOG, FEATURE); // warn at build time
-        recorder.warnJvmInNative(FEATURE); // warn at runtime
+    @Record(ExecutionTime.RUNTIME_INIT)
+    @BuildStep
+    CamelRuntimeBeanBuildItem quteComponent(CamelFreemarkerRecorder recorder, BeanContainerBuildItem beanContainer) {
+        // set the "real" Qute engine to the Camel Qute component
+        return new CamelRuntimeBeanBuildItem(
+                "qute",

Review comment:
       Qute?

##########
File path: integration-tests/activemq/src/test/java/org/apache/camel/quarkus/component/activemq/it/ActiveMQTest.java
##########
@@ -17,14 +17,13 @@
 package org.apache.camel.quarkus.component.activemq.it;
 
 import io.quarkus.test.common.QuarkusTestResource;
-import io.quarkus.test.junit.QuarkusTest;
 import io.restassured.RestAssured;
 import io.restassured.http.ContentType;
 import org.junit.jupiter.api.Test;
 
 import static org.hamcrest.core.Is.is;
 
-@QuarkusTest
+//@QuarkusTest

Review comment:
       I guess this wasn't supposed to be committed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org