You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/01/22 00:28:58 UTC
Review Request 30147: JAAS configuration file parser leaves trailing
quote in quoted values
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30147/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Jaimin Jetly.
Bugs: AMBARI-9244
https://issues.apache.org/jira/browse/AMBARI-9244
Repository: ambari
Description
-------
The JAAS configuration file parser used in determining the security state of some components (like ZooKeeper and HBase) leaves trailing quote in quoted values.
For example:
```
Client {
com.sun.security.auth.module.Krb5LoginModule required
useKeyTab=true
storeKey=true
useTicketCache=false
keyTab="/etc/security/keytabs/hbase.service.keytab"
principal="hbase/vp-ambari-ranger-med-0120-2.cs1cloud.internal@EXAMPLE.COM";
};
```
The value for `keytab` is being parsed as `/etc/security/keytabs/hbase.service.keytab"` rather than `/etc/security/keytabs/hbase.service.keytab`.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py 196ae34
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py 7f6ed00
Diff: https://reviews.apache.org/r/30147/diff/
Testing
-------
Manually tested in a test cluster
Updated `security_commons.py` on agent node exhibiting the issue - this fixed one of potenally a few issues related to Kerberized components.
Added unit test to resource_management.TestSecurityCommons.TestSecurityCommons
**NOTE: Tests still running in Jenkins**
Thanks,
Robert Levas
Re: Review Request 30147: JAAS configuration file parser leaves
trailing quote in quoted values
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30147/#review69096
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 21, 2015, 11:28 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30147/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 11:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Jaimin Jetly.
>
>
> Bugs: AMBARI-9244
> https://issues.apache.org/jira/browse/AMBARI-9244
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The JAAS configuration file parser used in determining the security state of some components (like ZooKeeper and HBase) leaves trailing quote in quoted values.
>
> For example:
>
> ```
> Client {
> com.sun.security.auth.module.Krb5LoginModule required
> useKeyTab=true
> storeKey=true
> useTicketCache=false
> keyTab="/etc/security/keytabs/hbase.service.keytab"
> principal="hbase/vp-ambari-ranger-med-0120-2.cs1cloud.internal@EXAMPLE.COM";
> };
> ```
> The value for `keytab` is being parsed as `/etc/security/keytabs/hbase.service.keytab"` rather than `/etc/security/keytabs/hbase.service.keytab`.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py 196ae34
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py 7f6ed00
>
> Diff: https://reviews.apache.org/r/30147/diff/
>
>
> Testing
> -------
>
> Manually tested in a test cluster
> Updated `security_commons.py` on agent node exhibiting the issue - this fixed one of potenally a few issues related to Kerberized components.
>
> Added unit test to resource_management.TestSecurityCommons.TestSecurityCommons
>
> **NOTE: Tests still running in Jenkins**
>
>
> Thanks,
>
> Robert Levas
>
>