You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sian January (JIRA)" <ji...@apache.org> on 2008/01/04 12:06:34 UTC

[jira] Created: (HARMONY-5370) [classlib] [pack200] Support for compressor-defined class file attributes

[classlib] [pack200] Support for compressor-defined class file attributes
-------------------------------------------------------------------------

                 Key: HARMONY-5370
                 URL: https://issues.apache.org/jira/browse/HARMONY-5370
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
            Reporter: Sian January
            Priority: Minor
         Attachments: pack200.patch

Attaching a patch that contains support for parsing non-predefined attributes.  Sorry the patch is quite big - it was quite a big piece of work and it was difficult to break it up...  

Support for adding the attributes to the class file is still to come.

This patch also removes all the empty pack() methods in pack200.  I had initially thought the same class hierarchy would do both pack and unpack but the code is getting really big now so we're going to use a separate set of classes for pack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5370) [classlib] [pack200] Support for compressor-defined class file attributes

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison reassigned HARMONY-5370:
------------------------------------

    Assignee: Tim Ellison

> [classlib] [pack200] Support for compressor-defined class file attributes
> -------------------------------------------------------------------------
>
>                 Key: HARMONY-5370
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5370
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Sian January
>            Assignee: Tim Ellison
>            Priority: Minor
>         Attachments: pack200.patch
>
>
> Attaching a patch that contains support for parsing non-predefined attributes.  Sorry the patch is quite big - it was quite a big piece of work and it was difficult to break it up...  
> Support for adding the attributes to the class file is still to come.
> This patch also removes all the empty pack() methods in pack200.  I had initially thought the same class hierarchy would do both pack and unpack but the code is getting really big now so we're going to use a separate set of classes for pack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5370) [classlib] [pack200] Support for compressor-defined class file attributes

Posted by "Sian January (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555898#action_12555898 ] 

Sian January commented on HARMONY-5370:
---------------------------------------

Thanks Tim - that was fast!

The patch was applied as expected.

> [classlib] [pack200] Support for compressor-defined class file attributes
> -------------------------------------------------------------------------
>
>                 Key: HARMONY-5370
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5370
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Sian January
>            Assignee: Tim Ellison
>            Priority: Minor
>         Attachments: pack200.patch
>
>
> Attaching a patch that contains support for parsing non-predefined attributes.  Sorry the patch is quite big - it was quite a big piece of work and it was difficult to break it up...  
> Support for adding the attributes to the class file is still to come.
> This patch also removes all the empty pack() methods in pack200.  I had initially thought the same class hierarchy would do both pack and unpack but the code is getting really big now so we're going to use a separate set of classes for pack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5370) [classlib] [pack200] Support for compressor-defined class file attributes

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-5370.
----------------------------------

    Resolution: Fixed

Thanks Sian.

Patch applied to PACK200 module at repo revision r608801.

Please check it was applied as you expected.


> [classlib] [pack200] Support for compressor-defined class file attributes
> -------------------------------------------------------------------------
>
>                 Key: HARMONY-5370
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5370
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Sian January
>            Assignee: Tim Ellison
>            Priority: Minor
>         Attachments: pack200.patch
>
>
> Attaching a patch that contains support for parsing non-predefined attributes.  Sorry the patch is quite big - it was quite a big piece of work and it was difficult to break it up...  
> Support for adding the attributes to the class file is still to come.
> This patch also removes all the empty pack() methods in pack200.  I had initially thought the same class hierarchy would do both pack and unpack but the code is getting really big now so we're going to use a separate set of classes for pack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5370) [classlib] [pack200] Support for compressor-defined class file attributes

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison closed HARMONY-5370.
--------------------------------


Verified by Sian.


> [classlib] [pack200] Support for compressor-defined class file attributes
> -------------------------------------------------------------------------
>
>                 Key: HARMONY-5370
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5370
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Sian January
>            Assignee: Tim Ellison
>            Priority: Minor
>         Attachments: pack200.patch
>
>
> Attaching a patch that contains support for parsing non-predefined attributes.  Sorry the patch is quite big - it was quite a big piece of work and it was difficult to break it up...  
> Support for adding the attributes to the class file is still to come.
> This patch also removes all the empty pack() methods in pack200.  I had initially thought the same class hierarchy would do both pack and unpack but the code is getting really big now so we're going to use a separate set of classes for pack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5370) [classlib] [pack200] Support for compressor-defined class file attributes

Posted by "Sian January (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sian January updated HARMONY-5370:
----------------------------------

    Attachment: pack200.patch

> [classlib] [pack200] Support for compressor-defined class file attributes
> -------------------------------------------------------------------------
>
>                 Key: HARMONY-5370
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5370
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Sian January
>            Priority: Minor
>         Attachments: pack200.patch
>
>
> Attaching a patch that contains support for parsing non-predefined attributes.  Sorry the patch is quite big - it was quite a big piece of work and it was difficult to break it up...  
> Support for adding the attributes to the class file is still to come.
> This patch also removes all the empty pack() methods in pack200.  I had initially thought the same class hierarchy would do both pack and unpack but the code is getting really big now so we're going to use a separate set of classes for pack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.