You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/16 06:05:14 UTC

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #254: feat: upstream retries and timeout

tokers opened a new pull request #254:
URL: https://github.com/apache/apisix-ingress-controller/pull/254


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #254: feat: upstream retries and timeout

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #254:
URL: https://github.com/apache/apisix-ingress-controller/pull/254#discussion_r578059802



##########
File path: pkg/types/apisix/v1/types.go
##########
@@ -62,6 +62,9 @@ const (
 	// ActiveHealthCheckMinInterval is the minimum interval for
 	// the active health check.
 	ActiveHealthCheckMinInterval = time.Second
+
+	// Default connect, read and send timeout with upstreams.
+	DefaultUpstreamTimeout = 60

Review comment:
       Added.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #254: feat: upstream retries and timeout

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #254:
URL: https://github.com/apache/apisix-ingress-controller/pull/254#discussion_r577566338



##########
File path: pkg/types/apisix/v1/types.go
##########
@@ -62,6 +62,9 @@ const (
 	// ActiveHealthCheckMinInterval is the minimum interval for
 	// the active health check.
 	ActiveHealthCheckMinInterval = time.Second
+
+	// Default connect, read and send timeout with upstreams.
+	DefaultUpstreamTimeout = 60

Review comment:
       Had better add `unit` in comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] gxthrj merged pull request #254: feat: upstream retries and timeout

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #254:
URL: https://github.com/apache/apisix-ingress-controller/pull/254


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #254: feat: upstream retries and timeout

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #254:
URL: https://github.com/apache/apisix-ingress-controller/pull/254#issuecomment-779606370


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=h1) Report
   > Merging [#254](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=desc) (2db0c83) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/419a76acf7481c8cce6446439cfd21e95ea54085?el=desc) (419a76a) will **increase** coverage by `0.18%`.
   > The diff coverage is `74.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #254      +/-   ##
   ==========================================
   + Coverage   48.13%   48.32%   +0.18%     
   ==========================================
     Files          36       35       -1     
     Lines        2202     2239      +37     
   ==========================================
   + Hits         1060     1082      +22     
   - Misses        999     1009      +10     
   - Partials      143      148       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRvci5nbw==) | `41.26% <0.00%> (-1.36%)` | :arrow_down: |
   | [pkg/kube/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2t1YmUvYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <65.62%> (-4.47%)` | :arrow_down: |
   | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.55% <100.00%> (+0.46%)` | :arrow_up: |
   | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `46.24% <100.00%> (+0.62%)` | :arrow_up: |
   | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=footer). Last update [419a76a...2db0c83](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #254: feat: upstream retries and timeout

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #254:
URL: https://github.com/apache/apisix-ingress-controller/pull/254#issuecomment-779606370


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=h1) Report
   > Merging [#254](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=desc) (b20cbe7) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/419a76acf7481c8cce6446439cfd21e95ea54085?el=desc) (419a76a) will **increase** coverage by `0.18%`.
   > The diff coverage is `74.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #254      +/-   ##
   ==========================================
   + Coverage   48.13%   48.32%   +0.18%     
   ==========================================
     Files          36       35       -1     
     Lines        2202     2239      +37     
   ==========================================
   + Hits         1060     1082      +22     
   - Misses        999     1009      +10     
   - Partials      143      148       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/kube/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRvci5nbw==) | `41.26% <0.00%> (-1.36%)` | :arrow_down: |
   | [pkg/kube/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2t1YmUvYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <65.62%> (-4.47%)` | :arrow_down: |
   | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.55% <100.00%> (+0.46%)` | :arrow_up: |
   | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `46.24% <100.00%> (+0.62%)` | :arrow_up: |
   | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
   | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=footer). Last update [419a76a...b20cbe7](https://codecov.io/gh/apache/apisix-ingress-controller/pull/254?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org