You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/10 00:58:12 UTC

[GitHub] [incubator-tvm] tqchen opened a new pull request #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure

tqchen opened a new pull request #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure
URL: https://github.com/apache/incubator-tvm/pull/4673
 
 
   This PR moves a few base types from relay and low-level Expr into the ir sub-folder.
   These classes will serve as a common type system across the stack.
   
   Rationale:
   
   - PrimExpr for low-level expressions
   - RelayExpr for advanced features, including Function definition.
   - Introduce BaseFunc to host all functions, including future PrimFunc(low-level expr functions, subject to discussion).
   
   This is a minimum change we can do to unify the classes into a common hierachy.
   The main data structure that are variant specific will still be kept in the sub-namespaces.
   We will only need the BaseFunc and their checked_type to decide the calling convention
   across the function variants.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure
URL: https://github.com/apache/incubator-tvm/pull/4673#issuecomment-572825641
 
 
   cc @jroesch @wweic @icemelon9 @yzhliu @merrymercy 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure
URL: https://github.com/apache/incubator-tvm/pull/4673
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4673: [REFACTOR][IR] Initialize Unified IR Expr Data Structure
URL: https://github.com/apache/incubator-tvm/pull/4673#issuecomment-572825641
 
 
   cc @jroesch @wweic @icemelon9 @yzhliu @merrymercy @ZihengJiang 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services