Re: Snapshot Strategy Review

[John Burwell <jb...@basho.com>]

Chris,

I have updated my comments in https://reviews.apache.org/r/14522/.   I will likely be offline the remainder of the day due to two sick kids + my own sickness.

Thanks,
-John


P.S.  I just noticed that this email thread was private to Edison and I.  All dev discussions should occur on the dev@ list.  Therefore, I have CC'ed this chain to the list, and please ensure that future replies to the email chain also include the dev@ list.

On Oct 17, 2013, at 1:28 PM, "SuichII, Christopher" <Ch...@netapp.com> wrote:

> John,
> 
> I'm glad to hear you think these changes look better. It sounds like everything else you mentioned is fairly minor, so I have no problems making some changes. However, I have made a couple comments on those issues regarding the direction you want to take with the context in error messages, how to DRY out the code (since the code is not actually duplicated) and I'm not sure if the UI portion I modified should be handling the 'corrupted' snapshots you're talking about.
> 
> Thanks!
> -Chris
> -- 
> Chris Suich
> chris.suich@netapp.com
> NetApp Software Engineer
> Data Center Platforms – Cloud Solutions
> Citrix, Cisco & Red Hat
> 
> On Oct 16, 2013, at 2:16 PM, Chris Suich <Ch...@netapp.com> wrote:
> 
>> No worries - I know I'm trying to push this quick so thanks for working with me on this.
>> 
>> -Chris
>> -- 
>> Chris Suich
>> chris.suich@netapp.com
>> NetApp Software Engineer
>> Data Center Platforms – Cloud Solutions
>> Citrix, Cisco & Red Hat
>> 
>> On Oct 16, 2013, at 2:02 PM, John Burwell <jb...@basho.com> wrote:
>> 
>>> Chris,
>>> 
>>> I saw it, but I have $dayjob priority ATM.  I will re-review late this
>>> evening or first thing tomorrow.  Dependent on the outcome, we can
>>> setup a call for late morning/early afternoon if necessary.
>>> 
>>> I apologize for the delay,
>>> -John
>>> 
>>> 
>>> 
>>> 
>>> On Oct 16, 2013, at 1:58 PM, "SuichII, Christopher"
>>> <Ch...@netapp.com> wrote:
>>> 
>>>> Hey John,
>>>> 
>>>> I know it hasn't been up long so you probably haven't seen it, but I posted another revision this morning. Maybe we could talk on the phone about this review so we can get this resolved ASAP? I'm thinking over the phone it might be quicker to clear up the objective of the changes and discuss what can be done now and what should be done in a later release.
>>>> 
>>>> Thanks,
>>>> Chris
>>>> --
>>>> Chris Suich
>>>> chris.suich@netapp.com
>>>> NetApp Software Engineer
>>>> Data Center Platforms – Cloud Solutions
>>>> Citrix, Cisco & Red Hat
>>>> 
>> 
> 

Re: Snapshot Strategy Review

["SuichII, Christopher" <Ch...@netapp.com>]

My apologies. Everything in the private email was also posted to the dev list, I just wanted to send a personal email to make sure you saw the update in your inbox.

-Chris
--
Chris Suich
chris.suich@netapp.com<ma...@netapp.com>
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

On Oct 17, 2013, at 1:45 PM, John Burwell <jb...@basho.com>> wrote:

Chris,

I have updated my comments in https://reviews.apache.org/r/14522/.   I will likely be offline the remainder of the day due to two sick kids + my own sickness.

Thanks,
-John


P.S.  I just noticed that this email thread was private to Edison and I.  All dev discussions should occur on the dev@ list.  Therefore, I have CC'ed this chain to the list, and please ensure that future replies to the email chain also include the dev@ list.

On Oct 17, 2013, at 1:28 PM, "SuichII, Christopher" <Ch...@netapp.com>> wrote:

John,

I'm glad to hear you think these changes look better. It sounds like everything else you mentioned is fairly minor, so I have no problems making some changes. However, I have made a couple comments on those issues regarding the direction you want to take with the context in error messages, how to DRY out the code (since the code is not actually duplicated) and I'm not sure if the UI portion I modified should be handling the 'corrupted' snapshots you're talking about.

Thanks!
-Chris
--
Chris Suich
chris.suich@netapp.com<ma...@netapp.com>
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

On Oct 16, 2013, at 2:16 PM, Chris Suich <Ch...@netapp.com>> wrote:

No worries - I know I'm trying to push this quick so thanks for working with me on this.

-Chris
--
Chris Suich
chris.suich@netapp.com<ma...@netapp.com>
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat

On Oct 16, 2013, at 2:02 PM, John Burwell <jb...@basho.com> wrote:

Chris,

I saw it, but I have $dayjob priority ATM.  I will re-review late this
evening or first thing tomorrow.  Dependent on the outcome, we can
setup a call for late morning/early afternoon if necessary.

I apologize for the delay,
-John




On Oct 16, 2013, at 1:58 PM, "SuichII, Christopher"
<Ch...@netapp.com> wrote:

Hey John,

I know it hasn't been up long so you probably haven't seen it, but I posted another revision this morning. Maybe we could talk on the phone about this review so we can get this resolved ASAP? I'm thinking over the phone it might be quicker to clear up the objective of the changes and discuss what can be done now and what should be done in a later release.

Thanks,
Chris
--
Chris Suich
chris.suich@netapp.com
NetApp Software Engineer
Data Center Platforms – Cloud Solutions
Citrix, Cisco & Red Hat