[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1419: Ordering by index in select expression

[GitBox <gi...@apache.org>]

xudong963 commented on a change in pull request #1419:
URL: https://github.com/apache/arrow-datafusion/pull/1419#discussion_r765831451



##########
File path: datafusion/src/sql/planner.rs
##########
@@ -1026,14 +1025,44 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
 
     /// convert sql OrderByExpr to Expr::Sort
     fn order_by_to_sort_expr(&self, e: &OrderByExpr, schema: &DFSchema) -> Result<Expr> {
+        let OrderByExpr {
+            asc,
+            expr,
+            nulls_first,
+        } = e;
+
+        let expr = match &expr {
+            SQLExpr::Value(Value::Number(v, _)) => {
+                let field_index = v
+                    .parse::<usize>()
+                    .map_err(|err| DataFusionError::Plan(err.to_string()))?;
+
+                if field_index == 0 {

Review comment:
       👍
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org